Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1153263012: MIPS64: Implement AddE lithium instruction to separate integer and address arithmetic. (Closed)

Created:
5 years, 6 months ago by dusmil.imgtec
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Implement AddE lithium instruction to separate integer and address arithmetic. This is required to have sign-extended int32 arithmetic operations by re-landing: https://codereview.chromium.org/1161713003 TEST=cctest/test-api/ArrayBuffer_JSInternalToExternal BUG= Committed: https://crrev.com/d2f5702c56fc9503efdd73931fca81e5f1fd2839 Cr-Commit-Position: refs/heads/master@{#28845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -14 lines) Patch
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +14 lines, -9 lines 0 comments Download
M src/mips64/lithium-mips64.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dusmil.imgtec
5 years, 6 months ago (2015-06-08 15:08:58 UTC) #2
balazs.kilvady
lgtm
5 years, 6 months ago (2015-06-08 16:16:13 UTC) #3
paul.l...
lgtm too.
5 years, 6 months ago (2015-06-08 16:59:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153263012/1
5 years, 6 months ago (2015-06-08 17:13:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 18:18:19 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 18:18:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2f5702c56fc9503efdd73931fca81e5f1fd2839
Cr-Commit-Position: refs/heads/master@{#28845}

Powered by Google App Engine
This is Rietveld 408576698