Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1153263004:
Unship harmony tostring (Closed)
|
Created:
5 years, 6 months ago by arv (Not doing code reviews) Modified:
5 years, 6 months ago CC:
v8-dev, jochen (gone - plz use gerrit), caitp (gmail) Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionUnship harmony tostring
Blink's DOM bindings are not yet ready.
BUG=493137, 239915
LOG=N
R=rossberg, adamk
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
Committed: https://crrev.com/07c1f277bd93dcbfef3c2dd2b256cdde5665289c
Cr-Commit-Position: refs/heads/master@{#28804}
Patch Set 1 #
Messages
Total messages: 27 (9 generated)
PTAL
LGTM, but you may want to change the subject to "Unship". ;)
On 2015/06/03 13:59:54, rossberg wrote: > LGTM, but you may want to change the subject to "Unship". ;) Done. I'll wait to commit until after today's meeting.
The CQ bit was checked by arv@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153263004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3159)
The CQ bit was checked by arv@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153263004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)
lgtm I've uploaded a fix for the blink tests in https://codereview.chromium.org/1154523007/
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153263004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153263004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153263004/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/07c1f277bd93dcbfef3c2dd2b256cdde5665289c Cr-Commit-Position: refs/heads/master@{#28804}
Message was sent while issue was closed.
On 2015/06/04 17:33:44, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/07c1f277bd93dcbfef3c2dd2b256cdde5665289c > Cr-Commit-Position: refs/heads/master@{#28804} Please fix layout test expectations.
Message was sent while issue was closed.
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/buil... inspector/console/console-format-es6.html
Message was sent while issue was closed.
On 2015/06/04 19:27:42, Michael Achenbach (OOO) wrote: > http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/buil... > inspector/console/console-format-es6.html I'm on it. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
