dart2js: Use frequency of occurence to sort metadata indices.

pkg/compiler/lib/src/js_emitter/model.dart

Index: pkg/compiler/lib/src/js_emitter/model.dart
diff --git a/pkg/compiler/lib/src/js_emitter/model.dart b/pkg/compiler/lib/src/js_emitter/model.dart
index 69eb6aebc503284df2fc46b7d317585e2475016f..2e937a820ad2a5cc8f0298151edc8d9e681a1fed 100644
--- a/pkg/compiler/lib/src/js_emitter/model.dart
+++ b/pkg/compiler/lib/src/js_emitter/model.dart
@@ -53,20 +53,19 @@ class Program {
   /// list must not be emitted before all operations on it are done. For
   /// example, the old emitter generates metadata when emitting reflection
   /// data.
-  List<js.Expression> get metadata => _metadataCollector.globalMetadata;
+  js.Expression get metadata => _metadataCollector.globalMetadata;
 
-  /// A map with lists of type expressions.
+  /// Getter for the list of metadata entries for a given [OutputUnit].

[karlklose, 2015/05/28 09:39:53]

Is is not a getter...

[herhut, 2015/06/01 12:09:42]

Done.

   ///
   /// There is one list for each output unit. The list belonging to the main
   /// unit must be emitted in the `TYPES` embedded global. The list references
   /// constants and must hence be emitted after constants have been initialized.
   ///
   /// Note: the metadata is derived from the task's `metadataCollector`. The
-  /// list must not be emitted before all operations on it are done. For
-  /// example, the old emitter generates metadata when emitting reflection
-  /// data.
-  Map<OutputUnit, List<js.Expression>> get metadataTypes
-      => _metadataCollector.types;
+  /// list is only a placeholder and will be filled in once metadata collection
+  /// is finalized.
+  js.Expression metadataTypesForOutputUnit(OutputUnit unit)
+      => _metadataCollector.getTypesForOutputUnit(unit);

[karlklose, 2015/05/28 09:39:53]

Use {} and return when it does not fit on one line.

[herhut, 2015/06/01 12:09:42]

Agree, I inherited this.

 
 
   bool get isSplit => fragments.length > 1;
@@ -236,7 +235,7 @@ class Class implements FieldContainer {
 
   // If the class implements a function type, and the type is encoded in the
   // metatada table, then this field contains the index into that field.
-  final int functionTypeIndex;
+  final js.Expression functionTypeIndex;

[sra1, 2015/05/27 19:38:51]

Could this be js.TokenNumber ?

[herhut, 2015/06/01 12:09:42]

I don't want to expose the fact that the result is a special thing outside of
the MetadataCollector. This code is not supposed to do anything with it.

 
   /// Whether the class must be evaluated eagerly.
   bool isEager = false;
@@ -283,7 +282,7 @@ class MixinApplication extends Class {
                    List<StubMethod> callStubs,
                    List<StubMethod> typeVariableReaderStubs,
                    List<StubMethod> isChecks,
-                   int functionTypeIndex,
+                   js.Expression functionTypeIndex,
                    {bool onlyForRti,
                     bool isDirectlyInstantiated})
       : super(element,