Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: pkg/compiler/lib/src/js/rewrite_async.dart

Issue 1153243003: dart2js: Use frequency of occurence to sort metadata indices. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Addressed sra's comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/dump_info.dart ('k') | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js/rewrite_async.dart
diff --git a/pkg/compiler/lib/src/js/rewrite_async.dart b/pkg/compiler/lib/src/js/rewrite_async.dart
index 9ea66a2a73e77221f38d4782a9fb324fa7329bed..d234cdff2e9dc4ec076261c5814355a49a58bc4b 100644
--- a/pkg/compiler/lib/src/js/rewrite_async.dart
+++ b/pkg/compiler/lib/src/js/rewrite_async.dart
@@ -1183,11 +1183,23 @@ abstract class AsyncRewriterBase extends js.NodeVisitor {
js.Expression visitLiteralString(js.LiteralString node) => node;
@override
+ js.Expression visitStringConcatenation(js.StringConcatenation node) => node;
+
+ @override
visitNamedFunction(js.NamedFunction node) {
unsupported(node);
}
@override
+ js.Expression visitDeferredExpression(js.DeferredExpression node) => node;
+
+ @override
+ js.Expression visitDeferredNumber(js.DeferredNumber node) => node;
+
+ @override
+ js.Expression visitDeferredString(js.DeferredString node) => node;
+
+ @override
js.Expression visitNew(js.New node) {
bool storeTarget = node.arguments.any(shouldTransform);
return withCallTargetExpression(node.target, (target) {
@@ -2385,6 +2397,21 @@ class PreTranslationAnalysis extends js.NodeVisitor<bool> {
}
@override
+ bool visitDeferredExpression(js.DeferredExpression node) {
+ return false;
+ }
+
+ @override
+ bool visitDeferredNumber(js.DeferredNumber node) {
+ return false;
+ }
+
+ @override
+ bool visitDeferredString(js.DeferredString node) {
+ return false;
+ }
+
+ @override
bool visitLiteralBool(js.LiteralBool node) {
return false;
}
@@ -2415,6 +2442,11 @@ class PreTranslationAnalysis extends js.NodeVisitor<bool> {
}
@override
+ bool visitStringConcatenation(js.StringConcatenation node) {
+ return true;
+ }
+
+ @override
bool visitNamedFunction(js.NamedFunction node) {
return false;
}
« no previous file with comments | « pkg/compiler/lib/src/dump_info.dart ('k') | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698