dart2js: Use frequency of occurence to sort metadata indices.

pkg/js_ast/lib/src/printer.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_ast;
 
 
 class JavaScriptPrintingOptions {
   final bool shouldCompressOutput;
   final bool minifyLocalVariables;
@@ skipping 934 matching lines @@
   }
 
   @override
   void visitFun(Fun fun) {
     VarCollector vars = new VarCollector();
     vars.visitFun(fun);
     currentNode.closingPosition = functionOut(fun, null, vars);
   }
 
   @override
-  void visitLiteralBool(LiteralBool node) {
+  visitTokenExpression(TokenExpression node) {
+    // Continue printing with the expression value.
+    node.value.accept(this);

[sra1, 2015/05/27 19:38:51]

Either the precedence needs to be fixed or this code needs to account for
'incorrect' precedence.

[herhut, 2015/06/09 11:10:00]

Done.

+  }
+
+  @override
+  visitTokenNumber(TokenNumber node) {
+    String value = "${node.value}";
+    int charCode = value.codeUnitAt(0);
+    if (charCode == charCodes.$MINUS && lastCharCode == charCodes.$MINUS) {
+      out(" ");

[sra1, 2015/05/27 20:30:15]

I'd like to see a test that covers this case.

[herhut, 2015/06/09 11:10:00]

I have factored out the logic from visitLiteralNumber (where this came from)
into a shared helper. So the actual code will be tested by the tests for
LiteralNumber and no special test for the deferred version is needed.

+    }
+    out(value);
+  }
+
+  @override
+  visitTokenString(TokenString node) {
+    out(node.value);
+  }
+
+  @override
+  visitLiteralBool(LiteralBool node) {
     out(node.value ? "true" : "false");
   }
 
   @override
   void visitLiteralString(LiteralString node) {
     out(node.value);
   }
 
   @override
-  void visitLiteralNumber(LiteralNumber node) {
+  visitStringConcatenation(StringConcatenation node) {
+    node.visitChildren(this);
+  }
+
+  @override
+  visitLiteralNumber(LiteralNumber node) {
     int charCode = node.value.codeUnitAt(0);
     if (charCode == charCodes.$MINUS && lastCharCode == charCodes.$MINUS) {
       out(" ", isWhitespace: true);
     }
     out(node.value);
   }
 
   @override
   void visitLiteralNull(LiteralNull node) {
     out("null");
@@ skipping 30 matching lines @@
 
   @override
   void visitObjectInitializer(ObjectInitializer node) {
     // Print all the properties on one line until we see a function-valued
     // property.  Ideally, we would use a proper pretty-printer to make the
     // decision based on layout.
     List<Property> properties = node.properties;
     out("{");
     indentMore();
     for (int i = 0; i < properties.length; i++) {
-      Expression value = properties[i].value;
       if (i != 0) {
         out(",");
         if (node.isOneLiner) spaceOut();
       }
       if (!node.isOneLiner) {
         forceLine();
         indent();
       }
       visit(properties[i]);
     }
@@ skipping 398 matching lines @@
     }
   }
 
   EnterExitNode exitNode(JavaScriptPrintingContext context, int position) {
     // Enter must happen before exit.
     addToNode(context, position);
     context.exitNode(node, startPosition, position, closingPosition);
     return parent;
   }
 }