Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1153233003: Re-land new insertion write barrier. (Closed)

Created:
5 years, 7 months ago by Hannes Payer (out of office)
Modified:
5 years, 6 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-land new insertion write barrier. BUG= Committed: https://crrev.com/72f850458cb530d871cf3fb6442660555dc51bc2 Cr-Commit-Position: refs/heads/master@{#29052}

Patch Set 1 #

Patch Set 2 : Extra check for black objects #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -27 lines) Patch
M src/heap/incremental-marking-inl.h View 1 1 chunk +6 lines, -20 lines 0 comments Download
M src/heap/spaces.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Hannes Payer (out of office)
5 years, 6 months ago (2015-06-16 07:32:42 UTC) #2
ulan
lgtm
5 years, 6 months ago (2015-06-16 10:04:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153233003/40001
5 years, 6 months ago (2015-06-16 14:21:27 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-16 14:23:01 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/72f850458cb530d871cf3fb6442660555dc51bc2 Cr-Commit-Position: refs/heads/master@{#29052}
5 years, 6 months ago (2015-06-16 14:23:15 UTC) #7
Hannes Payer (out of office)
5 years, 6 months ago (2015-06-18 18:04:22 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1176243015/ by hpayer@chromium.org.

The reason for reverting is: Deoptimizer crashes..

Powered by Google App Engine
This is Rietveld 408576698