Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1153233002: Correctly set ScriptState in the image loader microtask (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, tyoshino+watch_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Correctly set ScriptState in the image loader microtask BUG=487155 R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195981

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M Source/core/dom/Microtask.h View 1 chunk +4 lines, -0 lines 1 comment Download
M Source/core/loader/ImageLoader.cpp View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-27 08:46:42 UTC) #1
haraken
LGTM https://codereview.chromium.org/1153233002/diff/1/Source/core/dom/Microtask.h File Source/core/dom/Microtask.h (right): https://codereview.chromium.org/1153233002/diff/1/Source/core/dom/Microtask.h#newcode47 Source/core/dom/Microtask.h:47: // TODO(jochen): Make all microtasks pass in the ...
5 years, 7 months ago (2015-05-27 08:48:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153233002/1
5 years, 7 months ago (2015-05-27 08:50:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195981
5 years, 7 months ago (2015-05-27 14:57:19 UTC) #5
dmurph
5 years, 7 months ago (2015-05-27 21:05:56 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1162483002/ by dmurph@chromium.org.

The reason for reverting is: Tree on failure, might be causing the issues w/
leaking

https://code.google.com/p/chromium/issues/detail?id=492829&thanks=492829&ts=1....

Powered by Google App Engine
This is Rietveld 408576698