Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: tools/gn/function_exec_script.cc

Issue 115323009: Fix help and error messages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/filesystem_utils.cc ('k') | tools/gn/function_read_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_exec_script.cc
===================================================================
--- tools/gn/function_exec_script.cc (revision 243014)
+++ tools/gn/function_exec_script.cc (working copy)
@@ -245,8 +245,8 @@
"\n"
" The current directory when executing the script will be the root\n"
" build directory. If you are passing file names, you will want to use\n"
- " the to_build_dir() function to make file names relative to this\n"
- " path (see \"gn help to_build_dir\").\n"
+ " the rebase_path() function to make file names relative to this\n"
+ " path (see \"gn help rebase_path\").\n"
"\n"
"Arguments:\n"
"\n"
@@ -273,14 +273,15 @@
"Example:\n"
"\n"
" all_lines = exec_script(\"myscript.py\", [some_input], \"list lines\",\n"
- " [ to_build_dir(\"data_file.txt\") ])\n";
+ " [ rebase_path(\"data_file.txt\", \".\","
+ " root_build_dir) ])\n";
Value RunExecScript(Scope* scope,
const FunctionCallNode* function,
const std::vector<Value>& args,
Err* err) {
if (args.size() != 3 && args.size() != 4) {
- *err = Err(function->function(), "Wrong number of args to write_file",
+ *err = Err(function->function(), "Wrong number of arguments to exec_script",
"I expected three or four arguments.");
return Value();
}
« no previous file with comments | « tools/gn/filesystem_utils.cc ('k') | tools/gn/function_read_file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698