Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 115323009: Fix help and error messages. (Closed)

Created:
6 years, 11 months ago by halyavin
Modified:
6 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Fix help and error messages. I see a couple more to_build_path references and misprints but it is getting late. I am also not sure what to do with neologisms like "dependee" and "uniquify". BUG= none TEST= none R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243038

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -42 lines) Patch
M tools/gn/args.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M tools/gn/builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_args.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/command_desc.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_help.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/filesystem_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/function_exec_script.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M tools/gn/function_read_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/function_rebase_path.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/gn/function_set_defaults.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/function_template.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/function_toolchain.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/function_write_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/functions_target.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/gn/operators.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M tools/gn/parse_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/pattern.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/setup.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/variables.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
halyavin
Fix help and error messages. I see a couple more to_build_path references and misprints but ...
6 years, 11 months ago (2014-01-04 19:12:14 UTC) #1
halyavin
6 years, 11 months ago (2014-01-04 19:16:41 UTC) #2
brettw
I'm impressed. LGTM
6 years, 11 months ago (2014-01-04 22:54:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/halyavin@google.com/115323009/110002
6 years, 11 months ago (2014-01-05 07:24:53 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-05 11:15:31 UTC) #5
Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698