Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 115323006: [Android] Fix crash on opening context menu without default search engine. (Closed)

Created:
7 years ago by Kibeom Kim (inactive)
Modified:
7 years ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Fix crash on opening context menu without default search engine. BUG=278480 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241032

Patch Set 1 #

Patch Set 2 : TemplateUrl class javadoc #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Kibeom Kim (inactive)
7 years ago (2013-12-13 22:13:31 UTC) #1
Ted C
lgtm
7 years ago (2013-12-13 23:49:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/115323006/1
7 years ago (2013-12-13 23:55:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=41389
7 years ago (2013-12-14 00:27:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/115323006/20001
7 years ago (2013-12-14 00:49:34 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=203809
7 years ago (2013-12-14 01:19:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/115323006/20001
7 years ago (2013-12-14 02:03:39 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=203969
7 years ago (2013-12-14 04:38:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/115323006/40001
7 years ago (2013-12-14 22:10:50 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=202563
7 years ago (2013-12-14 23:10:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/115323006/40001
7 years ago (2013-12-14 23:12:27 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=184734
7 years ago (2013-12-15 01:45:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/115323006/60001
7 years ago (2013-12-16 19:33:06 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=205080
7 years ago (2013-12-16 21:25:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/115323006/60001
7 years ago (2013-12-16 21:33:40 UTC) #15
commit-bot: I haz the power
7 years ago (2013-12-16 21:37:09 UTC) #16
Message was sent while issue was closed. 
Change committed as 241032

Powered by Google App Engine
This is Rietveld 408576698