Issue 115323004: Improved SkPathRef interface security

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115323004: Improved SkPathRef interface security (Closed)

Created:
7 years ago by robertphillips

Modified:
7 years ago

Reviewers:
bsalomon, caryclark, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This still leaves the CreateEmpty/CreateTransformedCopy hole but (short of making a third class that exists solely to let SkPath access them) this at least improves things.

Patch Set 2 : Fix private pathref test pattern #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -72 lines)			Patch
M	include/core/SkPath.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	include/core/SkPathRef.h	View	1	8 chunks	+23 lines, -8 lines	0 comments	Download
M	src/core/SkPathRef.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/PathTest.cpp	View	1	4 chunks	+59 lines, -62 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertphillips

https://codereview.chromium.org/115323004/diff/1/src/core/SkPathRef.cpp File src/core/SkPathRef.cpp (left): https://codereview.chromium.org/115323004/diff/1/src/core/SkPathRef.cpp#oldcode26 src/core/SkPathRef.cpp:26: fPathRef->fGenerationID = 0; This is now deferred until points ...

7 years ago (2013-12-13 18:01:36 UTC) #1

Message was sent while issue was closed.

committed as r12676

Expand Messages | Collapse Messages

Issue 115323004: Improved SkPathRef interface security (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix private pathref test pattern #

Messages