Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1153223003: [Effen] Point the stocks2 and components2 files at the forked libraries. (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Point the stocks2 and components2 files at the forked libraries. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/af26195db7df7e34ee29cbd3ff6c7a717d2dd45d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -54 lines) Patch
M sky/examples/stocks2/lib/stock_app.dart View 1 chunk +13 lines, -13 lines 0 comments Download
M sky/examples/stocks2/lib/stock_list.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/stocks2/lib/stock_menu.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/examples/stocks2/lib/stock_row.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/framework/components2/animated_component.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/button.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/button_base.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/checkbox.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/drawer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/drawer_header.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/fixed_height_scrollable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/floating_action_button.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/icon.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/icon_button.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/ink_splash.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/ink_well.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/input.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/material.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/menu_divider.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/menu_item.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/modal_overlay.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/popup_menu.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/popup_menu_item.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/radio.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/scaffold.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/framework/components2/scrollable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/tool_bar.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 7 months ago (2015-05-27 16:07:39 UTC) #2
Hixie
5 years, 7 months ago (2015-05-27 16:13:42 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
af26195db7df7e34ee29cbd3ff6c7a717d2dd45d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698