Issue 1153213005: Extract argument-rewriting map-origin magic to devtoolslib/shell_arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153213005: Extract argument-rewriting map-origin magic to devtoolslib/shell_arguments. (Closed)

Created:
5 years, 6 months ago by ppi

Modified:
5 years, 6 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Extract argument-rewriting map-origin magic to devtoolslib/shell_arguments. This module will group functions that configure the shell before it is run while modifying its argument list (setting up servers for local origins, setting up the Mojo debugger). R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/77551bad23beb027febab8a0d59993a59cbb1f04

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Better names are better. #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -46 lines)			Patch
	A	mojo/devtools/common/devtoolslib/shell_arguments.py	View	1 2	1 chunk	+65 lines, -0 lines	0 comments	Download
	M	mojo/tools/android_mojo_shell.py	View	1 2	3 chunks	+3 lines, -46 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ppi

5 years, 6 months ago (2015-06-02 12:30:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
77551bad23beb027febab8a0d59993a59cbb1f04 (presubmit successful).

Expand Messages | Collapse Messages