Parameterize PushMessagingBrowserTest to work with bubbles & infobars

chrome/test/data/push_messaging/push_test.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 var resultQueue = new ResultQueue();
 var pushSubscription = null;
+var lastPermissionRequestResult = '';
 
 var pushSubscriptionOptions = {
   userVisibleOnly: true
 };
 
 // Sends data back to the test. This must be in response to an earlier
 // request, but it's ok to respond asynchronously. The request blocks until
 // the response is sent.
 function sendResultToTest(result) {
   console.log('sendResultToTest: ' + result);
@@ skipping 38 matching lines @@
 // Called by native. Immediately sends the next data item to the test if it is
 // available, otherwise sends null.
 ResultQueue.prototype.popImmediately = function() {
   sendResultToTest(this.queue.length ? this.queue.pop() : null);
 };
 
 // Notification permission has been coalesced with Push permission. After
 // this is granted, Push API subscription can succeed.
 function requestNotificationPermission() {
   Notification.requestPermission(function(permission) {
-    sendResultToTest('permission status - ' + permission);
+    lastPermissionRequestResult = permission;

[johnme, 2015/06/02 14:12:38]

What's the purpose of this change? Note that sendResultToTest is already an
asynchronous response mechanism.

Adding timeouts here seems to introduce unnecessary complexity and flakiness.
For example, I notice that 3 of the other patches in
https://code.google.com/p/chromium/issues/detail?id=438758 were reverted due to
flakiness :-o

   });
 }
 
+// The result of requesting permission in requestNotificationPermission() will
+// be sent back. If the permission request has not yet completed, try again
+// after a timeout.
+function getLastPermissionRequestResult(timeout) {
+  if (lastPermissionRequestResult === '')
+    window.setTimeout(getLastPermissionRequestResult, timeout);
+  else
+    sendResultToTest('permission status - ' + lastPermissionRequestResult);
+}
+
 function registerServiceWorker() {
   // The base dir used to resolve service_worker.js and the scope depends on
   // whether this script is included from an html file in ./, subscope1/, or
   // subscope2/.
   navigator.serviceWorker.register('service_worker.js', {scope: './'}).then(
       function(swRegistration) {
         sendResultToTest('ok - service worker registered');
       }, sendErrorToTest);
 }
 
@@ skipping 62 matching lines @@
     sendResultToTest(subscription ? 'true - subscribed'
                                   : 'false - not subscribed');
   }).catch(sendErrorToTest);
 }
 
 addEventListener('message', function(event) {
   var message = JSON.parse(event.data);
   if (message.type == 'push')
     resultQueue.push(message.data);
 }, false);