Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: content/browser/frame_host/navigator_impl_unittest.cc

Issue 1153193011: PlzNavigate: send Javascript urls synchronously to the renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated unit test now that data urls are sent committed synchronously Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator_impl_unittest.cc
diff --git a/content/browser/frame_host/navigator_impl_unittest.cc b/content/browser/frame_host/navigator_impl_unittest.cc
index 8dc64af604ff82a0801d11a6f63fae9fec9c4d45..d2e8e79d57a88bb523015ef2a1fe0935e22f00ed 100644
--- a/content/browser/frame_host/navigator_impl_unittest.cc
+++ b/content/browser/frame_host/navigator_impl_unittest.cc
@@ -970,16 +970,11 @@ TEST_F(NavigatorTestWithBrowserSideNavigation, DataUrls) {
contents()->NavigateAndCommit(kUrl1);
FrameTreeNode* node = main_test_rfh()->frame_tree_node();
- // Navigate to a data url.
+ // Navigate to a data url. The request should not have been sent to the IO
+ // thread but committed immediately.
int entry_id = RequestNavigation(node, kUrl2);
NavigationRequest* navigation_request = node->navigation_request();
ASSERT_TRUE(navigation_request);
- EXPECT_EQ(NavigationRequest::WAITING_FOR_RENDERER_RESPONSE,
- navigation_request->state());
- main_test_rfh()->SendBeforeUnloadACK(true);
-
- // The request should not have been sent to the IO thread but committed
- // immediately.
EXPECT_EQ(NavigationRequest::RESPONSE_STARTED,
navigation_request->state());
EXPECT_FALSE(navigation_request->loader_for_testing());
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698