Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: runtime/vm/object_test.cc

Issue 1153193006: Standardize on using "kind" to distinguish sub-varieties of a type. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: doc changes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
diff --git a/runtime/vm/object_test.cc b/runtime/vm/object_test.cc
index 6b3b907ff88b7ba914e92083750803de1f008c25..ac5dc2291144a48058602bc621372879da8742b6 100644
--- a/runtime/vm/object_test.cc
+++ b/runtime/vm/object_test.cc
@@ -4528,8 +4528,8 @@ TEST_CASE(PrintJSONPrimitives) {
JSONStream js;
Object::sentinel().PrintJSON(&js, true);
EXPECT_STREQ(
- "{\"type\":\"Sentinel\",\"fixedId\":true,"
- "\"id\":\"objects\\/not-initialized\","
+ "{\"type\":\"Sentinel\","
+ "\"kind\":\"NotInitialized\","
"\"valueAsString\":\"<not initialized>\"}",
js.ToCString());
}
@@ -4538,8 +4538,8 @@ TEST_CASE(PrintJSONPrimitives) {
JSONStream js;
Object::transition_sentinel().PrintJSON(&js, true);
EXPECT_STREQ(
- "{\"type\":\"Sentinel\",\"fixedId\":true,"
- "\"id\":\"objects\\/being-initialized\","
+ "{\"type\":\"Sentinel\","
+ "\"kind\":\"BeingInitialized\","
"\"valueAsString\":\"<being initialized>\"}",
js.ToCString());
}
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698