chrome/browser/ui/webui/print_preview/print_preview_handler.cc - Issue 1153173002: Include USB printers in printer list as "provisional" devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

Issue 1153173002: Include USB printers in printer list as "provisional" devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed more comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc ('k') | extensions/common/api/printer_provider/usb_printer_manifest_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc

index 0567ac7303ada8a505bd78d3f192289d89cabfbf..d80bb7a4f98fa503cdcee2e2386d17ddcdfe269d 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc

+++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc

@@ -1683,7 +1683,7 @@ void PrintPreviewHandler::FillPrinterDescription(

#endif // defined(ENABLE_SERVICE_DISCOVERY)

void PrintPreviewHandler::EnsureExtensionPrinterHandlerSet() {

- if (extension_printer_handler_.get())

+ if (extension_printer_handler_)

return;

extension_printer_handler_ =