Include USB printers in printer list as "provisional" devices.

chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/run_loop.h"
 #include "base/strings/string16.h"
+#include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/test/values_test_util.h"
 #include "base/values.h"
+#include "chrome/browser/extensions/test_extension_environment.h"
 #include "chrome/browser/local_discovery/pwg_raster_converter.h"
 #include "chrome/browser/ui/webui/print_preview/extension_printer_handler.h"
 #include "chrome/test/base/testing_profile.h"
-#include "content/public/test/test_browser_thread_bundle.h"
+#include "device/core/device_client.h"
+#include "device/usb/mock_usb_device.h"
+#include "device/usb/mock_usb_service.h"
+#include "extensions/browser/api/device_permissions_manager.h"
 #include "extensions/browser/api/printer_provider/printer_provider_api.h"
 #include "extensions/browser/api/printer_provider/printer_provider_api_factory.h"
 #include "extensions/browser/api/printer_provider/printer_provider_print_job.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/value_builder.h"
 #include "printing/pdf_render_settings.h"
 #include "printing/pwg_raster_settings.h"
 #include "printing/units.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/geometry/size.h"
 
+using device::MockUsbDevice;
+using device::MockUsbService;
+using extensions::DictionaryBuilder;
+using extensions::Extension;
 using extensions::PrinterProviderAPI;
 using extensions::PrinterProviderPrintJob;
+using extensions::TestExtensionEnvironment;
 using local_discovery::PWGRasterConverter;
 
 namespace {
 
 // Printer id used for requests in tests.
 const char kPrinterId[] = "printer_id";
 
 // Printer list used a result for getPrinters.
 const char kPrinterDescriptionList[] =
     "[{"
@@ skipping 68 matching lines @@
 
 // Print ticket that has duplex parameter set.
 const char kPrintTicketWithDuplex[] =
     "{"
     "  \"version\": \"1.0\","
     "  \"print\": {"
     "    \"duplex\": {\"type\": \"LONG_EDGE\"}"
     "  }"
     "}";
 
+// An extension with permission for 1 printer it supports.
+const char kExtension1[] =
+    "{"
+    "  \"name\": \"Provider 1\","
+    "  \"app\": {"
+    "    \"background\": {"
+    "      \"scripts\": [\"background.js\"]"
+    "    }"
+    "  },"
+    "  \"permissions\": ["
+    "    \"printerProvider\","
+    "    \"usb\","
+    "    {"
+    "     \"usbDevices\": ["
+    "       { \"vendorId\": 0, \"productId\": 1 }"
+    "     ]"
+    "    },"
+    "  ],"
+    "  \"usb_printers\": {"
+    "    \"filters\": ["
+    "      { \"vendorId\": 0, \"productId\": 0 },"
+    "      { \"vendorId\": 0, \"productId\": 1 }"
+    "    ]"
+    "  }"
+    "}";
+
+// An extension with permission for none of the printers it supports.
+const char kExtension2[] =
+    "{"
+    "  \"name\": \"Provider 2\","
+    "  \"app\": {"
+    "    \"background\": {"
+    "      \"scripts\": [\"background.js\"]"
+    "    }"
+    "  },"
+    "  \"permissions\": [ \"printerProvider\", \"usb\" ],"
+    "  \"usb_printers\": {"
+    "    \"filters\": ["
+    "      { \"vendorId\": 0, \"productId\": 0 },"
+    "      { \"vendorId\": 0, \"productId\": 1 }"
+    "    ]"
+    "  }"
+    "}";
+
 const char kContentTypePDF[] = "application/pdf";
 const char kContentTypePWG[] = "image/pwg-raster";
 
 // Print request status considered to be successful by fake PrinterProviderAPI.
 const char kPrintRequestSuccess[] = "OK";
 
 // Used as a callback to StartGetPrinters in tests.
 // Increases |*call_count| and records values returned by StartGetPrinters.
 void RecordPrinterList(size_t* call_count,
                        scoped_ptr<base::ListValue>* printers_out,
@@ skipping 218 matching lines @@
       pending_capability_callbacks_;
   std::vector<PrintRequestInfo> pending_print_requests_;
 
   DISALLOW_COPY_AND_ASSIGN(FakePrinterProviderAPI);
 };
 
 KeyedService* BuildTestingPrinterProviderAPI(content::BrowserContext* context) {
   return new FakePrinterProviderAPI();
 }
 
+class FakeDeviceClient : public device::DeviceClient {
+ public:
+  FakeDeviceClient() {}
+
+  // device::DeviceClient implementation:
+  device::UsbService* GetUsbService() override {
+    DCHECK(usb_service_);
+    return usb_service_;
+  }
+
+  void set_usb_service(device::UsbService* service) { usb_service_ = service; }
+
+ private:
+  device::UsbService* usb_service_ = nullptr;
+};
+
 }  // namespace
 
 class ExtensionPrinterHandlerTest : public testing::Test {
  public:
   ExtensionPrinterHandlerTest() : pwg_raster_converter_(NULL) {}
   ~ExtensionPrinterHandlerTest() override = default;
 
   void SetUp() override {
-    TestingProfile::Builder profile_builder;
-    profile_builder.AddTestingFactory(
-        extensions::PrinterProviderAPIFactory::GetInstance(),
-        &BuildTestingPrinterProviderAPI);
-    profile_ = profile_builder.Build();
-
+    env_.reset(new TestExtensionEnvironment());
+    extensions::PrinterProviderAPIFactory::GetInstance()->SetTestingFactory(
+        env_->profile(), &BuildTestingPrinterProviderAPI);
     extension_printer_handler_.reset(new ExtensionPrinterHandler(
-        profile_.get(), base::MessageLoop::current()->task_runner()));
+        env_->profile(), base::MessageLoop::current()->task_runner()));
 
     pwg_raster_converter_ = new FakePWGRasterConverter();
     extension_printer_handler_->SetPwgRasterConverterForTesting(
         scoped_ptr<PWGRasterConverter>(pwg_raster_converter_));
+    device_client_.set_usb_service(&usb_service_);
   }
 
  protected:
   FakePrinterProviderAPI* GetPrinterProviderAPI() {
     return static_cast<FakePrinterProviderAPI*>(
         extensions::PrinterProviderAPIFactory::GetInstance()
-            ->GetForBrowserContext(profile_.get()));
+            ->GetForBrowserContext(env_->profile()));
   }
 
+  MockUsbService usb_service_;
+  scoped_ptr<TestExtensionEnvironment> env_;

[Vitaly Buka (NO REVIEWS), 2015/05/28 22:50:55]

maybe just TestExtensionEnvironment env_;

   scoped_ptr<ExtensionPrinterHandler> extension_printer_handler_;
 
   FakePWGRasterConverter* pwg_raster_converter_;
 
  private:
-  content::TestBrowserThreadBundle thread_bundle_;
-
-  scoped_ptr<TestingProfile> profile_;
+  FakeDeviceClient device_client_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionPrinterHandlerTest);
 };
 
 TEST_F(ExtensionPrinterHandlerTest, GetPrinters) {
   size_t call_count = 0;
   scoped_ptr<base::ListValue> printers;
   bool is_done = false;
 
   extension_printer_handler_->StartGetPrinters(
@@ skipping 36 matching lines @@
   std::string error;
   scoped_ptr<base::ListValue> original_printers(
       GetJSONAsListValue(kPrinterDescriptionList, &error));
   ASSERT_TRUE(original_printers) << "Error deserializing printers: " << error;
 
   fake_api->TriggerNextGetPrintersCallback(*original_printers, true);
 
   EXPECT_EQ(0u, call_count);
 }
 
+TEST_F(ExtensionPrinterHandlerTest, GetUsbPrinters) {
+  scoped_refptr<MockUsbDevice> device0 =
+      new MockUsbDevice(0, 0, "Google", "USB Printer", "");
+  usb_service_.AddDevice(device0);
+  scoped_refptr<MockUsbDevice> device1 =
+      new MockUsbDevice(0, 1, "Google", "USB Printer", "");
+  usb_service_.AddDevice(device1);
+
+  const Extension* extension_1 = env_->MakeExtension(
+      *base::test::ParseJson(kExtension1), "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
+  const Extension* extension_2 = env_->MakeExtension(
+      *base::test::ParseJson(kExtension2), "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb");
+
+  extensions::DevicePermissionsManager* permissions_manager =
+      extensions::DevicePermissionsManager::Get(env_->profile());
+  permissions_manager->AllowUsbDevice(extension_2->id(), device0);
+
+  size_t call_count = 0;
+  scoped_ptr<base::ListValue> printers;
+  bool is_done = false;
+  extension_printer_handler_->StartGetPrinters(
+      base::Bind(&RecordPrinterList, &call_count, &printers, &is_done));
+
+  FakePrinterProviderAPI* fake_api = GetPrinterProviderAPI();
+  ASSERT_TRUE(fake_api);
+  ASSERT_EQ(1u, fake_api->pending_get_printers_count());
+
+  EXPECT_EQ(1u, call_count);
+  EXPECT_FALSE(is_done);
+  EXPECT_TRUE(printers.get());
+  EXPECT_EQ(2u, printers->GetSize());
+  scoped_ptr<base::DictionaryValue> extension_1_entry(
+      DictionaryBuilder()
+          .Set("id", base::StringPrintf("provisional-usb:%s:%u",
+                                        extension_1->id().c_str(),
+                                        device0->unique_id()))
+          .Set("name", "USB Printer")
+          .Set("extensionName", "Provider 1")
+          .Set("extensionId", extension_1->id())
+          .Set("provisional", true)
+          .Build());
+  scoped_ptr<base::DictionaryValue> extension_2_entry(
+      DictionaryBuilder()
+          .Set("id", base::StringPrintf("provisional-usb:%s:%u",
+                                        extension_2->id().c_str(),
+                                        device1->unique_id()))
+          .Set("name", "USB Printer")
+          .Set("extensionName", "Provider 2")
+          .Set("extensionId", extension_2->id())
+          .Set("provisional", true)
+          .Build());
+  EXPECT_TRUE(printers->Find(*extension_1_entry) != printers->end());
+  EXPECT_TRUE(printers->Find(*extension_2_entry) != printers->end());
+
+  fake_api->TriggerNextGetPrintersCallback(base::ListValue(), true);
+
+  EXPECT_EQ(2u, call_count);
+  EXPECT_TRUE(is_done);
+  EXPECT_TRUE(printers.get());
+  EXPECT_EQ(0u, printers->GetSize());  // RecordPrinterList resets |printers|.
+}
+
 TEST_F(ExtensionPrinterHandlerTest, GetCapability) {
   size_t call_count = 0;
   std::string destination_id;
   scoped_ptr<base::DictionaryValue> capability;
 
   extension_printer_handler_->StartGetCapability(
       kPrinterId,
       base::Bind(&RecordCapability, &call_count, &destination_id, &capability));
 
   EXPECT_EQ(0u, call_count);
@@ skipping 325 matching lines @@
   extension_printer_handler_->StartPrint(
       kPrinterId, kPWGRasterOnlyPrinterSimpleDescription, title,
       kEmptyPrintTicket, gfx::Size(100, 100), print_data,
       base::Bind(&RecordPrintResult, &call_count, &success, &status));
 
   EXPECT_EQ(1u, call_count);
 
   EXPECT_FALSE(success);
   EXPECT_EQ("INVALID_DATA", status);
 }