Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1153163003: Add flag to enable MJPEG acceleration for video capture (Closed)

Created:
5 years, 6 months ago by kcwu
Modified:
5 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, dzhioev+watch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, henryhsu
Base URL:
https://chromium.googlesource.com/chromium/src.git@mjpeg-4-use
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add flag to enable MJPEG acceleration for video capture BUG=335778 TEST=apprtc.appspot.com on intel platform Committed: https://crrev.com/31f102404a479372d3ea4299acb0a4da2340b6af Cr-Commit-Position: refs/heads/master@{#336560}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M build/ios/grit_whitelist.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc View 1 2 3 4 3 chunks +8 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1132683004 Patch 340001

Messages

Total messages: 10 (3 generated)
kcwu
@asvitkine, please owner review histograms.xml @piman, the rest, please. Thanks In summary, there are total ...
5 years, 6 months ago (2015-06-08 14:10:14 UTC) #2
piman
lgtm https://codereview.chromium.org/1153163003/diff/20001/content/browser/renderer_host/gpu_jpeg_decoder.cc File content/browser/renderer_host/gpu_jpeg_decoder.cc (right): https://codereview.chromium.org/1153163003/diff/20001/content/browser/renderer_host/gpu_jpeg_decoder.cc#newcode28 content/browser/renderer_host/gpu_jpeg_decoder.cc:28: #if defined(OS_CHROMEOS) && defined(ARCH_CPU_X86_FAMILY) nit: do you want ...
5 years, 6 months ago (2015-06-08 21:25:03 UTC) #3
Alexei Svitkine (slow)
histograms lgtm
5 years, 6 months ago (2015-06-08 21:27:55 UTC) #4
kcwu
https://codereview.chromium.org/1153163003/diff/20001/content/browser/renderer_host/gpu_jpeg_decoder.cc File content/browser/renderer_host/gpu_jpeg_decoder.cc (right): https://codereview.chromium.org/1153163003/diff/20001/content/browser/renderer_host/gpu_jpeg_decoder.cc#newcode28 content/browser/renderer_host/gpu_jpeg_decoder.cc:28: #if defined(OS_CHROMEOS) && defined(ARCH_CPU_X86_FAMILY) On 2015/06/08 21:25:03, piman (Very ...
5 years, 6 months ago (2015-06-09 09:05:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153163003/80001
5 years, 5 months ago (2015-06-29 13:26:20 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 5 months ago (2015-06-29 14:58:31 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 14:59:17 UTC) #10
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/31f102404a479372d3ea4299acb0a4da2340b6af
Cr-Commit-Position: refs/heads/master@{#336560}

Powered by Google App Engine
This is Rietveld 408576698