Fix race condition in WebstoreInstallHelper

chrome/browser/bitmap_fetcher/bitmap_fetcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h"
 
 #include "content/public/browser/browser_thread.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "net/url_request/url_request_status.h"
@@ skipping 19 matching lines @@
   url_fetcher_->SetRequestContext(request_context);
   url_fetcher_->SetReferrer(referrer);
   url_fetcher_->SetReferrerPolicy(referrer_policy);
   url_fetcher_->SetLoadFlags(load_flags);
   url_fetcher_->Start();
 }
 
 // Methods inherited from URLFetcherDelegate.
 
 void BitmapFetcher::OnURLFetchComplete(const net::URLFetcher* source) {
-  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

[Marc Treib, 2015/05/27 08:23:04]

I don't think this DCHECK should be here. It's the only thread check in the
whole file, and I see no reason why this should only be allowed on the UI
thread.

-
   if (source->GetStatus().status() != net::URLRequestStatus::SUCCESS) {
     ReportFailure();
     return;
   }
 
   std::string image_data;
   source->GetResponseAsString(&image_data);
 
   // Call start to begin decoding.  The ImageDecoder will call OnImageDecoded
   // with the data when it is done.
@@ skipping 15 matching lines @@
 
 void BitmapFetcher::OnDecodeImageFailed() {
   ReportFailure();
 }
 
 void BitmapFetcher::ReportFailure() {
   delegate_->OnFetchComplete(url_, NULL);
 }
 
 }  // namespace chrome