custom-tabs: Add and deliver the start/finish navigation callbacks.

custom-tabs: Add and deliver the start/finish navigation callbacks.

This replaces the only "onUserNavigation" callback with
"onUserNavigationStarted" and "onUserNavigationFinished", and delivers
it.

Note: this change modifies the Service AIDL file, so this is an
incompatible change for the client applications.

BUG=484639
Committed: https://crrev.com/4d306ff30b22ca6c7741ad996c101b7ce2a61965
Cr-Commit-Position: refs/heads/master@{#333037}

[Benoit L, 2015-06-03 17:37:57]

lizeb@chromium.org changed reviewers:
+ yusufo@chromium.org

[Benoit L, 2015-06-03 17:37:57]

Hello yusufo,

Here is the navigation callback CL. It is a rewrite of the previous one, with:
- Start and Finish callbacks
- Callbacks are delivered for all navigations.

Note that the "finish" callback is delivered the same way it is for Webview, as
far as I can tell. However this is not exactly identical to the "start" case for
webview.

[Yusuf, 2015-06-03 18:27:34]

https://codereview.chromium.org/1153133004/diff/1/chrome/android/java_staging...
File
chrome/android/java_staging/src/org/chromium/chrome/browser/hosted/HostedTab.java
(right):

https://codereview.chromium.org/1153133004/diff/1/chrome/android/java_staging...
chrome/android/java_staging/src/org/chromium/chrome/browser/hosted/HostedTab.java:52:
private CallbackTabObserver mCallbackTabObserver;
where do we create and add this?

[Benoit L, 2015-06-03 19:22:31]

Oops, sorry about that, bad rebase...

https://codereview.chromium.org/1153133004/diff/1/chrome/android/java_staging...
File
chrome/android/java_staging/src/org/chromium/chrome/browser/hosted/HostedTab.java
(right):

https://codereview.chromium.org/1153133004/diff/1/chrome/android/java_staging...
chrome/android/java_staging/src/org/chromium/chrome/browser/hosted/HostedTab.java:52:
private CallbackTabObserver mCallbackTabObserver;
On 2015/06/03 18:27:34, Yusuf wrote:
> where do we create and add this?

Sorry about that, a bad rebase.
Fixed.

[Yusuf, 2015-06-03 20:25:35]

lgtm

[Benoit L, 2015-06-05 11:50:57]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2015-06-05 11:50:57]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/1153133004/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-06-05 11:51:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1153133004/60001

[commit-bot: I haz the power, 2015-06-05 12:13:58]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-05 12:14:53]

Patchset 4 (id:??) landed as
https://crrev.com/4d306ff30b22ca6c7741ad996c101b7ce2a61965
Cr-Commit-Position: refs/heads/master@{#333037}