Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: src/ppc/full-codegen-ppc.cc

Issue 1153113002: PPC: Move work to omit unnecessary ObjectLiteral stores to the numbering pass. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_PPC 7 #if V8_TARGET_ARCH_PPC
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1616 matching lines...) Expand 10 before | Expand all | Expand 10 after
1627 } else { 1627 } else {
1628 FastCloneShallowObjectStub stub(isolate(), expr->properties_count()); 1628 FastCloneShallowObjectStub stub(isolate(), expr->properties_count());
1629 __ CallStub(&stub); 1629 __ CallStub(&stub);
1630 } 1630 }
1631 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG); 1631 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG);
1632 1632
1633 // If result_saved is true the result is on top of the stack. If 1633 // If result_saved is true the result is on top of the stack. If
1634 // result_saved is false the result is in r3. 1634 // result_saved is false the result is in r3.
1635 bool result_saved = false; 1635 bool result_saved = false;
1636 1636
1637 // Mark all computed expressions that are bound to a key that
1638 // is shadowed by a later occurrence of the same key. For the
1639 // marked expressions, no store code is emitted.
1640 expr->CalculateEmitStore(zone());
1641
1642 AccessorTable accessor_table(zone()); 1637 AccessorTable accessor_table(zone());
1643 int property_index = 0; 1638 int property_index = 0;
1644 for (; property_index < expr->properties()->length(); property_index++) { 1639 for (; property_index < expr->properties()->length(); property_index++) {
1645 ObjectLiteral::Property* property = expr->properties()->at(property_index); 1640 ObjectLiteral::Property* property = expr->properties()->at(property_index);
1646 if (property->is_computed_name()) break; 1641 if (property->is_computed_name()) break;
1647 if (property->IsCompileTimeValue()) continue; 1642 if (property->IsCompileTimeValue()) continue;
1648 1643
1649 Literal* key = property->key()->AsLiteral(); 1644 Literal* key = property->key()->AsLiteral();
1650 Expression* value = property->value(); 1645 Expression* value = property->value();
1651 if (!result_saved) { 1646 if (!result_saved) {
(...skipping 3814 matching lines...) Expand 10 before | Expand all | Expand 10 after
5466 return ON_STACK_REPLACEMENT; 5461 return ON_STACK_REPLACEMENT;
5467 } 5462 }
5468 5463
5469 DCHECK(interrupt_address == 5464 DCHECK(interrupt_address ==
5470 isolate->builtins()->OsrAfterStackCheck()->entry()); 5465 isolate->builtins()->OsrAfterStackCheck()->entry());
5471 return OSR_AFTER_STACK_CHECK; 5466 return OSR_AFTER_STACK_CHECK;
5472 } 5467 }
5473 } 5468 }
5474 } // namespace v8::internal 5469 } // namespace v8::internal
5475 #endif // V8_TARGET_ARCH_PPC 5470 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698