Add a layout test for plugins::PluginPlaceholder.

Add a layout test for plugins::PluginPlaceholder.

BUG=436562
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196270

[chrishtr, 2015-06-01 20:55:03]

chrishtr@chromium.org changed reviewers:
+ schenney@chromium.org

[Stephen Chennney, 2015-06-01 21:04:16]

I'm not seeing what would cause red to appear on failure, but I haven't dug into
the plugin test that gets embedded.

I believe the plugins test are all skipped on Linux, so those expectations are
superfluous (TestExpectations line 291)

Finally, I believe you need 2 paints because there is code in the embed loader
that explicitly delays a frame to avoid load contention or something like that.
It got me into trouble when trying to do the plugin layout code and nobody has
had time to try to figure out if it's still necessary and/or desirable.

[chrishtr, 2015-06-01 21:12:07]

On 2015/06/01 at 21:04:16, schenney wrote:
> I'm not seeing what would cause red to appear on failure, but I haven't dug
into the plugin test that gets embedded.

What do you mean by red? I don't understand what you are getting at.

> 
> I believe the plugins test are all skipped on Linux, so those expectations are
superfluous (TestExpectations line 291)

Yes, but we need a rebaseline for all platforms. I made it a pixel test because
this is really a smoke test for this type of plugin.

> 
> Finally, I believe you need 2 paints because there is code in the embed loader
that explicitly delays a frame to avoid load contention or something like that.
It got me into trouble when trying to do the plugin layout code and nobody has
had time to try to figure out if it's still necessary and/or desirable.

[Stephen Chennney, 2015-06-01 21:16:58]

On 2015/06/01 21:12:07, chrishtr wrote:
> On 2015/06/01 at 21:04:16, schenney wrote:
> > I'm not seeing what would cause red to appear on failure, but I haven't dug
> into the plugin test that gets embedded.
> 
> What do you mean by red? I don't understand what you are getting at.

I see, the png is a placeholder, not test output. The text on the png result
says "see red" so I was looking for some red in the test file.

> > I believe the plugins test are all skipped on Linux, so those expectations
are
> superfluous (TestExpectations line 291)
> 
> Yes, but we need a rebaseline for all platforms. I made it a pixel test
because
> this is really a smoke test for this type of plugin.

Just making sure you tested somewhere other than linux.

lgtm

[chrishtr, 2015-06-01 21:30:54]

On 2015/06/01 at 21:16:58, schenney wrote:
> On 2015/06/01 21:12:07, chrishtr wrote:
> > On 2015/06/01 at 21:04:16, schenney wrote:
> > > I'm not seeing what would cause red to appear on failure, but I haven't
dug
> > into the plugin test that gets embedded.
> > 
> > What do you mean by red? I don't understand what you are getting at.
> 
> I see, the png is a placeholder, not test output. The text on the png result
says "see red" so I was looking for some red in the test file.
> 
> > > I believe the plugins test are all skipped on Linux, so those expectations
are
> > superfluous (TestExpectations line 291)
> > 
> > Yes, but we need a rebaseline for all platforms. I made it a pixel test
because
> > this is really a smoke test for this type of plugin.
> 
> Just making sure you tested somewhere other than linux.
> 
> lgtm

Ah. No I did not, but will watch the rebaseline CL.

[chrishtr, 2015-06-01 21:30:58]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-06-01 21:31:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1153103004/80001

[commit-bot: I haz the power, 2015-06-01 23:49:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-01 23:49:55]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[chrishtr, 2015-06-01 23:50:39]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-06-01 23:52:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1153103004/80001

[commit-bot: I haz the power, 2015-06-02 01:37:46]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196270