Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1153103003: [test] Remove default for zero test cases. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Remove default for zero test cases. BUG= Committed: https://crrev.com/4d6f1abbdb48b5f5ea00af120456d35db7553993 Cr-Commit-Position: refs/heads/master@{#28654}

Patch Set 1 : Hack to show how it looks like. #

Patch Set 2 : Remove hack #

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M tools/run-tests.py View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M tools/testrunner/local/progress.py View 1 2 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Achenbach
PTAL. Any reason why that is needed? I'd like to remove it to always enforce ...
5 years, 7 months ago (2015-05-26 19:45:28 UTC) #2
Jakob Kummerow
Here's a reason; this happens when I apply this patch: $ tools/run-tests.py --arch x64 --mode ...
5 years, 7 months ago (2015-05-27 08:28:46 UTC) #3
Michael Achenbach
How about this fix? I found only this one corner case. The alternative would be ...
5 years, 7 months ago (2015-05-27 09:27:24 UTC) #4
Jakob Kummerow
OK, LGTM.
5 years, 7 months ago (2015-05-27 10:49:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153103003/40001
5 years, 7 months ago (2015-05-27 13:26:43 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-27 13:50:47 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 13:50:59 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4d6f1abbdb48b5f5ea00af120456d35db7553993
Cr-Commit-Position: refs/heads/master@{#28654}

Powered by Google App Engine
This is Rietveld 408576698