Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1153093004: Added CQ config to skia repo (Closed)

Created:
5 years, 6 months ago by Sergiy Byelozyorov
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git/@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Added CQ config to skia repo This must land in sync with https://chromereviews.googleplex.com/204307013 and revert in sync. R=rmistry@chromium.org, tandrii@chromium.org NOTRY=true NOTREECHECKS=true BUG=chromium:471767 Committed: https://skia.googlesource.com/skia/+/2baef5a1e104fe635c5b71fcdae159ba171c662c

Patch Set 1 #

Total comments: 5

Patch Set 2 #

Patch Set 3 : Addressed comments #

Patch Set 4 : Added explanation of directories in infra/ to the README.md #

Patch Set 5 : Renamed README to README.md in project-config dir #

Patch Set 6 : Addressed comments #

Patch Set 7 : Updated README.md #

Patch Set 8 : Added a comment to refs.cfg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -1 line) Patch
M infra/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
D infra/README View 1 chunk +0 lines, -1 line 0 comments Download
A infra/README.md View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
A infra/branch-config/README.md View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A infra/branch-config/cq.cfg View 1 2 3 4 5 1 chunk +48 lines, -0 lines 0 comments Download
D infra/project-config/README View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
A + infra/project-config/README.md View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/project-config/refs.cfg View 1 2 3 4 5 6 7 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Sergiy Byelozyorov
5 years, 6 months ago (2015-06-05 12:33:05 UTC) #1
tandrii(chromium)
lgtm
5 years, 6 months ago (2015-06-05 16:19:25 UTC) #3
rmistry
There is already a project-config/ dir that nodir had created, can we re-use that one? ...
5 years, 6 months ago (2015-06-08 11:39:15 UTC) #6
Sergiy Byelozyorov
On 2015/06/08 11:39:15, rmistry wrote: > There is already a project-config/ dir that nodir had ...
5 years, 6 months ago (2015-06-08 11:45:26 UTC) #7
rmistry
On 2015/06/08 11:45:26, Sergiy Byelozyorov wrote: > On 2015/06/08 11:39:15, rmistry wrote: > > There ...
5 years, 6 months ago (2015-06-08 11:51:48 UTC) #8
rmistry
LGTM https://codereview.chromium.org/1153093004/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/1153093004/diff/1/infra/config/cq.cfg#newcode4 infra/config/cq.cfg:4: version: 1 On 2015/06/08 11:45:26, Sergiy Byelozyorov wrote: ...
5 years, 6 months ago (2015-06-08 12:03:01 UTC) #10
Sergiy Byelozyorov
On 2015/06/08 12:03:01, rmistry wrote: > LGTM > > https://codereview.chromium.org/1153093004/diff/1/infra/config/cq.cfg > File infra/config/cq.cfg (right): > ...
5 years, 6 months ago (2015-06-08 12:08:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153093004/140001
5 years, 6 months ago (2015-06-08 12:09:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153093004/140001
5 years, 6 months ago (2015-06-08 12:10:03 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153093004/140001
5 years, 6 months ago (2015-06-08 12:12:24 UTC) #20
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 12:13:01 UTC) #21
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/2baef5a1e104fe635c5b71fcdae159ba171c662c

Powered by Google App Engine
This is Rietveld 408576698