Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Unified Diff: net/url_request/url_request_backoff_manager_unittest.cc

Issue 1153093002: Implement URLRequestBackoffManager for managing Backoff headers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed tests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_backoff_manager.cc ('k') | net/url_request/url_request_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_backoff_manager_unittest.cc
diff --git a/net/url_request/url_request_backoff_manager_unittest.cc b/net/url_request/url_request_backoff_manager_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..21a892e9d344db8559d6250f4b3645429c37ea04
--- /dev/null
+++ b/net/url_request/url_request_backoff_manager_unittest.cc
@@ -0,0 +1,117 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/url_request/url_request_backoff_manager.h"
+
+#include "base/memory/scoped_ptr.h"
+#include "base/strings/stringprintf.h"
+#include "base/time/time.h"
+#include "net/http/http_response_headers.h"
+#include "net/http/http_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+
+namespace {
+
+class URLRequestBackoffManagerTest : public testing::Test {
+ protected:
+ URLRequestBackoffManagerTest() : manager_(new URLRequestBackoffManager) {}
+ void RegisterURL(const GURL& url,
+ int backoff_in_sec,
+ const base::Time& request_time) {
+ std::string raw_headers = base::StringPrintf(
+ "HTTP/1.0 200 OK\n"
+ "backoff: %d\n\n",
+ backoff_in_sec);
+ scoped_refptr<HttpResponseHeaders> headers(new HttpResponseHeaders(
+ HttpUtil::AssembleRawHeaders(raw_headers.c_str(), raw_headers.size())));
+ manager_->UpdateWithResponse(url, headers.get(), request_time);
+ }
+
+ scoped_ptr<URLRequestBackoffManager> manager_;
+};
+} // namespace
+
+TEST_F(URLRequestBackoffManagerTest, ShouldRejectRequest) {
+ base::Time request_time = base::Time::Now();
+ RegisterURL(GURL("https://example.com"), 3600, request_time);
+ ASSERT_EQ(1, manager_->GetNumberOfEntriesForTests());
+ ASSERT_TRUE(manager_->ShouldRejectRequest(
+ GURL("https://example.com?q=v"),
+ request_time + base::TimeDelta::FromSeconds(3500)));
+
+ // Only can try once in the interval of
+ // [|request_time| + 3600, |request_time| + 3600 * 1.1).
+ ASSERT_FALSE(manager_->ShouldRejectRequest(
+ GURL("https://example.com?q=v"),
+ request_time + base::TimeDelta::FromSeconds(3700)));
+ ASSERT_TRUE(manager_->ShouldRejectRequest(
+ GURL("https://example.com?q=v"),
+ request_time + base::TimeDelta::FromSeconds(3700)));
+ ASSERT_EQ(1, manager_->GetNumberOfEntriesForTests());
+
+ // After release time, throttling should not be applied.
+ ASSERT_FALSE(manager_->ShouldRejectRequest(
+ GURL("https://example.com?q=v"),
+ request_time + base::TimeDelta::FromSeconds(3960)));
+}
+
+TEST_F(URLRequestBackoffManagerTest, MisconfiguredHeaders) {
+ // Backoff time is smaller than the minimum allowed.
+ RegisterURL(GURL("https://example.com"),
+ URLRequestBackoffManager::kMinimumBackoffInSeconds - 1,
+ base::Time::Now());
+ ASSERT_EQ(0, manager_->GetNumberOfEntriesForTests());
+
+ // Backoff time is bigger than the maximum allowed.
+ RegisterURL(GURL("https://example.com"),
+ URLRequestBackoffManager::kMaximumBackoffInSeconds + 1,
+ base::Time::Now());
+ ASSERT_EQ(0, manager_->GetNumberOfEntriesForTests());
+}
+
+TEST_F(URLRequestBackoffManagerTest, ShouldGarbageCollect) {
+ base::Time request_time =
+ base::Time::Now() - base::TimeDelta::FromSeconds(60);
+ for (int i = 0;
+ i < URLRequestBackoffManager::kNewEntriesBetweenCollecting - 1; i++) {
+ RegisterURL(GURL(base::StringPrintf("http://example%d.com", i)), 10,
+ request_time);
+ ASSERT_EQ(i + 1, manager_->GetNumberOfEntriesForTests());
+ }
+ // Should clear all previous outdated entries.
+ RegisterURL(GURL("http://example.com"), 10, base::Time::Now());
+ ASSERT_EQ(1, manager_->GetNumberOfEntriesForTests());
+}
+
+TEST_F(URLRequestBackoffManagerTest, ClearOnNetworkChange) {
+ for (int i = 0; i < 3; ++i) {
+ RegisterURL(GURL("http://www.example.com/"), 60, base::Time::Now());
+ ASSERT_EQ(1, manager_->GetNumberOfEntriesForTests());
+ EXPECT_TRUE(manager_->ShouldRejectRequest(GURL("http://www.example.com/"),
+ base::Time::Now()));
+ switch (i) {
+ case 0:
+ manager_->OnIPAddressChanged();
+ break;
+ case 1:
+ manager_->OnConnectionTypeChanged(
+ NetworkChangeNotifier::CONNECTION_UNKNOWN);
+ break;
+ case 2:
+ manager_->OnConnectionTypeChanged(
+ NetworkChangeNotifier::CONNECTION_NONE);
+ break;
+ default:
+ FAIL();
+ }
+
+ EXPECT_FALSE(manager_->ShouldRejectRequest(GURL("http://www.example.com/"),
+ base::Time::Now()));
+ ASSERT_EQ(0, manager_->GetNumberOfEntriesForTests());
+ }
+}
+
+} // namespace net
« no previous file with comments | « net/url_request/url_request_backoff_manager.cc ('k') | net/url_request/url_request_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698