net/base/net_error_list.h - Issue 1153093002: Implement URLRequestBackoffManager for managing Backoff headers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/base/net_error_list.h

Issue 1153093002: Implement URLRequestBackoffManager for managing Backoff headers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | net/net.gypi » ('j') | net/url_request/url_request_context_builder.cc » ('J')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // This file intentionally does not have header guards, it's included	5 // This file intentionally does not have header guards, it's included

6 // inside a macro to generate enum values.	6 // inside a macro to generate enum values.

7	7

8 // This file contains the list of network errors.	8 // This file contains the list of network errors.

9	9

10 //	10 //

(...skipping 785 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
796 NET_ERROR(DNS_TIMED_OUT, -803)	796 NET_ERROR(DNS_TIMED_OUT, -803)

797	797

798 // The entry was not found in cache, for cache-only lookups.	798 // The entry was not found in cache, for cache-only lookups.

799 NET_ERROR(DNS_CACHE_MISS, -804)	799 NET_ERROR(DNS_CACHE_MISS, -804)

800	800

801 // Suffix search list rules prevent resolution of the given host name.	801 // Suffix search list rules prevent resolution of the given host name.

802 NET_ERROR(DNS_SEARCH_EMPTY, -805)	802 NET_ERROR(DNS_SEARCH_EMPTY, -805)

803	803

804 // Failed to sort addresses according to RFC3484.	804 // Failed to sort addresses according to RFC3484.

805 NET_ERROR(DNS_SORT_ERROR, -806)	805 NET_ERROR(DNS_SORT_ERROR, -806)

	806

	807 // Request is throttled because of Backoff header.

	808 NET_ERROR(TEMPORARY_BACKOFF, -807)
	mmenke 2015/07/07 21:33:10 The 8xx errors are used for DNS errors. The -3xx The 8xx errors are used for DNS errors. The -3xx error codes seem a better fit. mmenke 2015/07/07 21:33:10 Should add an error page for this, since this is a Should add an error page for this, since this is an expected error that can be triggered by the server. See localized_error.cc and generated_resources.grd. xunjieli 2015/07/08 16:10:49 Done. I see! I missed the comments at the top. Show quoted text On 2015/07/07 21:33:10, mmenke wrote: > The 8xx errors are used for DNS errors. The -3xx error codes seem a better fit. Done. I see! I missed the comments at the top. xunjieli 2015/07/08 16:10:49 Done. Show quoted text On 2015/07/07 21:33:10, mmenke wrote: > Should add an error page for this, since this is an expected error that can be > triggered by the server. See localized_error.cc and generated_resources.grd. Done.
OLD	NEW