Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2097)

Unified Diff: app/os_exchange_data_win_unittest.cc

Issue 115309: Remove even more ATL dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « app/os_exchange_data_win.cc ('k') | chrome/browser/browser_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/os_exchange_data_win_unittest.cc
===================================================================
--- app/os_exchange_data_win_unittest.cc (revision 16052)
+++ app/os_exchange_data_win_unittest.cc (working copy)
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include <atlbase.h>
-#include <shlobj.h>
-
#include "app/os_exchange_data.h"
#include "base/clipboard_util.h"
#include "base/pickle.h"
@@ -42,7 +39,7 @@
OSExchangeData* data = new OSExchangeData;
std::wstring input = L"O hai googlz.";
data->SetString(input);
- CComPtr<IDataObject> com_data(data);
+ ScopedComPtr<IDataObject> com_data(data);
FORMATETC format_etc =
{ CF_UNICODETEXT, NULL, DVASPECT_CONTENT, -1, TYMED_HGLOBAL };
@@ -54,8 +51,6 @@
ScopedHGlobal<wchar_t>(medium.hGlobal).get();
EXPECT_EQ(input, output);
ReleaseStgMedium(&medium);
-
- // data is freed automatically by CComPtr.
}
// Test setting using the IDataObject COM API
@@ -63,7 +58,7 @@
OSExchangeData* data = new OSExchangeData;
std::wstring input = L"http://www.google.com/";
- CComPtr<IDataObject> com_data(data);
+ ScopedComPtr<IDataObject> com_data(data);
// Store data in the object using the COM SetData API.
CLIPFORMAT cfstr_ineturl = RegisterClipboardFormat(CFSTR_INETURL);
@@ -98,7 +93,7 @@
OSExchangeData* data = new OSExchangeData;
GURL url("http://www.google.com/");
data->SetURL(url, L"");
- CComPtr<IDataObject> com_data(data);
+ ScopedComPtr<IDataObject> com_data(data);
CLIPFORMAT cfstr_ineturl = RegisterClipboardFormat(CFSTR_INETURL);
FORMATETC format_etc =
@@ -121,7 +116,7 @@
data->SetURL(url, L"Google");
data->SetString(text);
- CComPtr<IDataObject> com_data(data);
+ ScopedComPtr<IDataObject> com_data(data);
CLIPFORMAT cfstr_ineturl = RegisterClipboardFormat(CFSTR_INETURL);
FORMATETC url_format_etc =
@@ -156,9 +151,10 @@
RegisterClipboardFormat(CFSTR_FILEDESCRIPTOR);
CLIPFORMAT text_x_moz_url = RegisterClipboardFormat(L"text/x-moz-url");
- CComPtr<IDataObject> com_data(data);
- CComPtr<IEnumFORMATETC> enumerator;
- EXPECT_EQ(S_OK, com_data->EnumFormatEtc(DATADIR_GET, &enumerator));
+ ScopedComPtr<IDataObject> com_data(data);
+ ScopedComPtr<IEnumFORMATETC> enumerator;
+ EXPECT_EQ(S_OK, com_data.get()->EnumFormatEtc(DATADIR_GET,
+ enumerator.Receive()));
// Test that we can get one item.
{
@@ -210,9 +206,9 @@
{
EXPECT_EQ(S_OK, enumerator->Reset());
EXPECT_EQ(S_OK, enumerator->Skip(1));
- CComPtr<IEnumFORMATETC> cloned_enumerator;
- EXPECT_EQ(S_OK, enumerator->Clone(&cloned_enumerator));
- EXPECT_EQ(S_OK, enumerator->Reset());
+ ScopedComPtr<IEnumFORMATETC> cloned_enumerator;
+ EXPECT_EQ(S_OK, enumerator.get()->Clone(cloned_enumerator.Receive()));
+ EXPECT_EQ(S_OK, enumerator.get()->Reset());
{
ULONG retrieved = 0;
@@ -257,7 +253,7 @@
EXPECT_EQ(url_spec, WideToUTF8(output_string));
// File contents access via COM
- CComPtr<IDataObject> com_data(data);
+ ScopedComPtr<IDataObject> com_data(data);
{
CLIPFORMAT cfstr_file_contents =
RegisterClipboardFormat(CFSTR_FILECONTENTS);
« no previous file with comments | « app/os_exchange_data_win.cc ('k') | chrome/browser/browser_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698