Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 1153083002: sync-and-gyp: make smarter (Closed)

Created:
5 years, 7 months ago by hal.canary
Modified:
5 years, 7 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

sync-and-gyp: make smarter This fixes two issues: If gyp is run with the CXX and CC environment variables set, it will produce different ninja build files. sync-and-gyp now tracks the values of those variables; if they change, re-run gyp. Secondly, we introduced find.py, which is used inside gyp files. If the contents of certain directories changes, gyp should be re-run. So now we track those directories too. Committed: https://skia.googlesource.com/skia/+/43315bbe4b39073bb8a585cc806eb50a72224e5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M bin/sync-and-gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hal.canary
PTAL This fixes two issues: If gyp is run with the CXX and CC environment ...
5 years, 7 months ago (2015-05-26 14:06:02 UTC) #2
scroggo
On 2015/05/26 14:06:02, Hal Canary wrote: > PTAL > > This fixes two issues: If ...
5 years, 7 months ago (2015-05-26 14:12:55 UTC) #3
hal.canary
On 2015/05/26 14:12:55, scroggo wrote: > Did you mean to add find.py? (It looks like ...
5 years, 7 months ago (2015-05-26 14:49:35 UTC) #4
scroggo
On 2015/05/26 14:49:35, Hal Canary wrote: > On 2015/05/26 14:12:55, scroggo wrote: > > Did ...
5 years, 7 months ago (2015-05-26 14:54:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153083002/1
5 years, 7 months ago (2015-05-26 14:55:00 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 15:01:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/43315bbe4b39073bb8a585cc806eb50a72224e5a

Powered by Google App Engine
This is Rietveld 408576698