Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1153073002: [test] Correctly merge expected test outcomes. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Correctly merge expected test outcomes. Without this change, wildcards always overwrite the outcomes of more specific rules. Now we always merge. Committed: https://crrev.com/a2b6dfb2d103112c87a48e6442a72b468d6ec26e Cr-Commit-Position: refs/heads/master@{#28629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/testrunner/local/testsuite.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/testrunner/objects/testcase.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 7 months ago (2015-05-26 12:43:19 UTC) #2
Jakob Kummerow
lgtm
5 years, 7 months ago (2015-05-26 12:54:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153073002/1
5 years, 7 months ago (2015-05-26 12:56:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-26 13:22:22 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 13:22:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2b6dfb2d103112c87a48e6442a72b468d6ec26e
Cr-Commit-Position: refs/heads/master@{#28629}

Powered by Google App Engine
This is Rietveld 408576698