Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1153053005: Cleanup ast numbering for super.prop in arrows (Closed)

Created:
5 years, 7 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup ast numbering for super.prop in arrows Follow up to https://codereview.chromium.org/1135243004 For now we need to call set_base_id in AstNumberingVisitor because TurboFan needs a bailout id for super.prop in a lot of cases. BUG=None LOG=N R=adamk@chromium.org, mstarzinger@chromium.org Committed: https://crrev.com/ab0577b29c3d7cf0c451a3ecb7f85e87d8d8d160 Cr-Commit-Position: refs/heads/master@{#28689}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove a commented out loc that was left over #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M src/ast-numbering.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
arv (Not doing code reviews)
PTAL I accidentally left some incorrect code in there.
5 years, 7 months ago (2015-05-26 20:57:23 UTC) #1
adamk
https://codereview.chromium.org/1153053005/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (left): https://codereview.chromium.org/1153053005/diff/1/src/compiler/ast-graph-builder.cc#oldcode2228 src/compiler/ast-graph-builder.cc:2228: if (expr->obj()->IsSuperReference()) { Your last comment on the previous ...
5 years, 7 months ago (2015-05-26 21:00:10 UTC) #2
arv (Not doing code reviews)
https://codereview.chromium.org/1153053005/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (left): https://codereview.chromium.org/1153053005/diff/1/src/compiler/ast-graph-builder.cc#oldcode2228 src/compiler/ast-graph-builder.cc:2228: if (expr->obj()->IsSuperReference()) { On 2015/05/26 21:00:09, adamk wrote: > ...
5 years, 7 months ago (2015-05-26 21:03:46 UTC) #3
adamk
lgtm
5 years, 7 months ago (2015-05-26 21:40:55 UTC) #4
arv (Not doing code reviews)
Remove a commented out loc that was left over
5 years, 6 months ago (2015-05-28 18:14:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153053005/20001
5 years, 6 months ago (2015-05-28 18:15:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-05-28 18:50:44 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 18:51:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab0577b29c3d7cf0c451a3ecb7f85e87d8d8d160
Cr-Commit-Position: refs/heads/master@{#28689}

Powered by Google App Engine
This is Rietveld 408576698