Issue 1153033010: Make OKNet not throw bananas when asked to parse 'banana'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153033010: Make OKNet not throw bananas when asked to parse 'banana'. (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make OKNet not throw bananas when asked to parse 'banana'. Catch the MalformedURLException instead of dying. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/61473c11eb5499421ba133b6a702512efa2cad84

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
	M	sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java	View		2 chunks	+18 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

eseidel

5 years, 6 months ago (2015-06-03 23:53:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
61473c11eb5499421ba133b6a702512efa2cad84 (presubmit successful).