components/autofill/core/common/password_form_field_predictions.h - Issue 1153023004: Prepare the infrastructure for password overrides.

Side by Side Diff: components/autofill/core/common/password_form_field_predictions.h

Issue 1153023004: Prepare the infrastructure for password overrides. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/autofill/content/renderer/password_form_conversion_utils.cc ('k') | components/password_manager/content/browser/content_password_manager_driver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_PASSWORD_FORM_FIELD_PREDICTIONS_H_

	6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_PASSWORD_FORM_FIELD_PREDICTIONS_H_

	7

	8 #include <map>

	9

	10 #include "components/autofill/core/common/form_field_data.h"

	11

	12 namespace autofill {

	13

	14 enum PasswordFormFieldPredictionType {

	15 PREDICTION_USERNAME,
	vabr (Chromium) 2015/05/27 13:31:51 Would it make sense to use ServerFieldType instead Would it make sense to use ServerFieldType instead? msramek 2015/05/27 14:38:35 I wanted to give GetPasswordForm() a more explicit Show quoted text On 2015/05/27 13:31:51, vabr (Chromium) wrote: > Would it make sense to use ServerFieldType instead? I wanted to give GetPasswordForm() a more explicit input, but it could work directly with ServerFieldType too. I don't have such a strong opinion on this. However, it cannot be done directly, as ServerFieldType is in browser/, and this needs to stay in common/ (these messages are sent from renderer to browser). vabr (Chromium) 2015/05/28 07:53:32 Acknowledged, can stay as it is. Would you conside Show quoted text On 2015/05/27 14:38:35, msramek wrote: > On 2015/05/27 13:31:51, vabr (Chromium) wrote: > > Would it make sense to use ServerFieldType instead? > > I wanted to give GetPasswordForm() a more explicit input, but it could work > directly with ServerFieldType too. I don't have such a strong opinion on this. > > However, it cannot be done directly, as ServerFieldType is in browser/, and this > needs to stay in common/ (these messages are sent from renderer to browser). Acknowledged, can stay as it is. Would you consider putting in a code comment explaining that this does not use ServerFieldType, because that type is currently in browser/ instead of common/? msramek 2015/05/28 19:36:48 Done. Show quoted text On 2015/05/28 07:53:32, vabr (Chromium) wrote: > On 2015/05/27 14:38:35, msramek wrote: > > On 2015/05/27 13:31:51, vabr (Chromium) wrote: > > > Would it make sense to use ServerFieldType instead? > > > > I wanted to give GetPasswordForm() a more explicit input, but it could work > > directly with ServerFieldType too. I don't have such a strong opinion on this. > > > > However, it cannot be done directly, as ServerFieldType is in browser/, and > this > > needs to stay in common/ (these messages are sent from renderer to browser). > > Acknowledged, can stay as it is. Would you consider putting in a code comment > explaining that this does not use ServerFieldType, because that type is > currently in browser/ instead of common/? Done.
	16 PREDICTION_CURRENT_PASSWORD,

	17 PREDICTION_NEW_PASSWORD,

	18 PREDICTION_MAX = PREDICTION_NEW_PASSWORD

	19 };

	20

	21 using PasswordFormFieldPredictions =

	22 std::map<PasswordFormFieldPredictionType, FormFieldData>;
	Ilya Sherman 2015/05/27 18:21:50 nit: I'd prefer to avoid this typedef/using stmt e nit: I'd prefer to avoid this typedef/using stmt entirely. However, if you do keep it, please name the type "PasswordFormFieldPredictionMap". "PredictionMap" indicates a map, whereas a simply plural "Predictions", by convention, indicates a vector or other type of list. msramek 2015/05/28 19:36:48 I'd prefer not to add a file for so little content Show quoted text On 2015/05/27 18:21:50, Ilya Sherman wrote: > nit: I'd prefer to avoid this typedef/using stmt entirely. However, if you do > keep it, please name the type "PasswordFormFieldPredictionMap". "PredictionMap" > indicates a map, whereas a simply plural "Predictions", by convention, indicates > a vector or other type of list. I'd prefer not to add a file for so little content either, but currently this seems like the most reasonable approach. I'll keep it in mind; eventually, we might want to give even more autofill information to password manager and then we'll definitely want to reuse ServerFieldType. Renamed to Map.
	23

	24 } // namespace autofill

	25

	26 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_PASSWORD_FORM_FIELD_PREDICTIONS_H_

OLD	NEW