lib/runtime/dart/_js_names.js - Issue 1153003003: fixes #40, extension methods for primitive types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/runtime/dart/_js_names.js

Issue 1153003003: fixes #40, extension methods for primitive types (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/runtime/dart/_js_names.js

diff --git a/lib/runtime/dart/_js_names.js b/lib/runtime/dart/_js_names.js

index d4c8722ab31ea2568e00c58b549b1b33bca4cd74..ae22d851269453216709aa0f1f9201a461ec8e40 100644

--- a/lib/runtime/dart/_js_names.js

+++ b/lib/runtime/dart/_js_names.js

@@ -34,8 +34,8 @@ var _js_helper = dart.lazyImport(_js_helper);

let value = jsMangledNames[key];

result.set(key, value);

if (!dart.notNull(isGlobal)) {

- if (key.startsWith(getterPrefix)) {

- result.set(`${setterPrefix}${key.substring(getterPrefixLength)}`, `${value}=`);

+ if (key[dartx.startsWith](getterPrefix)) {

+ result.set(`${setterPrefix}${key[dartx.substring](getterPrefixLength)}`, `${value}=`);

}