Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11530005: Wrapers for PRINTER_INFO_* and DRIVER_INFO_*. (Closed)

Created:
8 years ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years ago
Reviewers:
gene
CC:
chromium-reviews
Visibility:
Public.

Description

Wrapers for PRINTER_INFO_* and DRIVER_INFO_*. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172552

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -235 lines) Patch
M printing/backend/print_backend_win.cc View 1 2 3 4 5 2 chunks +26 lines, -79 lines 0 comments Download
A printing/backend/printing_info_win.h View 1 1 chunk +91 lines, -0 lines 0 comments Download
A printing/backend/printing_info_win.cc View 1 1 chunk +66 lines, -0 lines 0 comments Download
M printing/backend/win_helper.cc View 6 chunks +27 lines, -62 lines 0 comments Download
M printing/printing.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/printing_context_win.h View 1 chunk +0 lines, -4 lines 0 comments Download
M printing/printing_context_win.cc View 1 2 3 4 5 6 4 chunks +8 lines, -76 lines 0 comments Download
M printing/printing_context_win_unittest.cc View 4 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
Please review.
8 years ago (2012-12-11 07:50:50 UTC) #1
gene
https://codereview.chromium.org/11530005/diff/1/printing/backend/print_backend_win.cc File printing/backend/print_backend_win.cc (right): https://codereview.chromium.org/11530005/diff/1/printing/backend/print_backend_win.cc#newcode135 printing/backend/print_backend_win.cc:135: DevMode devmode; call variable user_settings ? https://codereview.chromium.org/11530005/diff/1/printing/backend/printing_info_win.h File printing/backend/printing_info_win.h ...
8 years ago (2012-12-11 18:03:31 UTC) #2
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/11530005/diff/1/printing/backend/printing_info_win.h File printing/backend/printing_info_win.h (right): https://codereview.chromium.org/11530005/diff/1/printing/backend/printing_info_win.h#newcode71 printing/backend/printing_info_win.h:71: class PRINTING_EXPORT DevMode { On 2012/12/11 18:03:31, gene wrote: ...
8 years ago (2012-12-11 19:24:24 UTC) #3
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/11530005/diff/1/printing/backend/print_backend_win.cc File printing/backend/print_backend_win.cc (right): https://codereview.chromium.org/11530005/diff/1/printing/backend/print_backend_win.cc#newcode135 printing/backend/print_backend_win.cc:135: DevMode devmode; On 2012/12/11 18:03:31, gene wrote: > call ...
8 years ago (2012-12-11 19:26:28 UTC) #4
gene
lgtm On 2012/12/11 19:26:28, Vitaly Buka wrote: > https://codereview.chromium.org/11530005/diff/1/printing/backend/print_backend_win.cc > File printing/backend/print_backend_win.cc (right): > > ...
8 years ago (2012-12-11 19:32:01 UTC) #5
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/11530005/diff/8003/printing/printing_context_win.cc File printing/printing_context_win.cc (right): https://codereview.chromium.org/11530005/diff/8003/printing/printing_context_win.cc#newcode619 printing/printing_context_win.cc:619: } done
8 years ago (2012-12-11 19:35:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/11530005/15003
8 years ago (2012-12-12 05:35:43 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-12 07:25:44 UTC) #8
Message was sent while issue was closed. 
Change committed as 172552

Powered by Google App Engine
This is Rietveld 408576698