Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1152993005: Fix more -Wsign-compare bugs with GCC 4.9.2 (Closed)

Created:
5 years, 6 months ago by Djordje.Pesic
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix more -Wsign-compare bugs with GCC 4.9.2 Committed: https://crrev.com/ac1d19208cb97f98ee2d7e21d7fca376feabf78f Cr-Commit-Position: refs/heads/master@{#28800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -84 lines) Patch
M test/cctest/test-assembler-mips.cc View 2 chunks +84 lines, -84 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dusmil.imgtec
lgtm.
5 years, 6 months ago (2015-06-04 09:55:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152993005/1
5 years, 6 months ago (2015-06-04 11:17:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-04 11:45:15 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 11:45:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac1d19208cb97f98ee2d7e21d7fca376feabf78f
Cr-Commit-Position: refs/heads/master@{#28800}

Powered by Google App Engine
This is Rietveld 408576698