Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1152983004: Move ObserverList to base namespace. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org, creis+watch_chromium.org, piman+watch_chromium.org, mlamouri+watch-content_chromium.org, Ian Vollick, nasko+codewatch_chromium.org, jam, sadrul, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org, erikwright+watch_chromium.org, glider+watch_chromium.org, danakj+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ObserverList to base namespace. Moves ObserverList and related classes to the base namespace. ObserverList[ThreadSafe] maintains a using statement to avoid having to update all users atomically. Users of ObserverListBase are updated in this patch. BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/5a1613dcb83ac548403796eb1320d17dad52ccd8 Cr-Commit-Position: refs/heads/master@{#332347}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -77 lines) Patch
M base/observer_list.h View 3 chunks +12 lines, -5 lines 0 comments Download
M base/observer_list_threadsafe.h View 12 chunks +37 lines, -26 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/renderer_context_menu/render_view_context_menu_base.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/mock_render_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/extensions_api_client.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M extensions/browser/api/extensions_api_client.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M ipc/ipc_test_sink.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/network_change_notifier.cc View 1 chunk +10 lines, -9 lines 0 comments Download
M net/cert/cert_database.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M net/cert/nss_cert_database.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/client/plugin/delegating_signal_strategy.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/register_support_host_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/signaling/fake_signal_strategy.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/signaling/xmpp_signal_strategy.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/drmemory/suppressions_full.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_animation_sequence.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_animator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/compound_event_filter.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
brettw
5 years, 6 months ago (2015-06-01 17:41:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152983004/1
5 years, 6 months ago (2015-06-01 17:43:22 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/76545) linux_chromium_gn_dbg on ...
5 years, 6 months ago (2015-06-01 17:56:33 UTC) #6
sky
LGTM
5 years, 6 months ago (2015-06-01 18:12:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152983004/20001
5 years, 6 months ago (2015-06-01 18:26:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/62784)
5 years, 6 months ago (2015-06-01 18:46:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152983004/40001
5 years, 6 months ago (2015-06-01 19:21:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152983004/60001
5 years, 6 months ago (2015-06-01 20:12:37 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/64523)
5 years, 6 months ago (2015-06-01 23:44:41 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152983004/60001
5 years, 6 months ago (2015-06-02 04:22:28 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-02 05:34:54 UTC) #23
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 05:35:53 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5a1613dcb83ac548403796eb1320d17dad52ccd8
Cr-Commit-Position: refs/heads/master@{#332347}

Powered by Google App Engine
This is Rietveld 408576698