Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1152943004: [OSX] Revert deferred-window change for FramedBrowserWindow. (Closed)

Created:
5 years, 6 months ago by Scott Hess - ex-Googler
Modified:
5 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[OSX] Revert deferred-window change for FramedBrowserWindow. The change from defer:YES to defer:NO appears to have caused a perf regression in startup.warm.blank_page . My best hypothesis is that Chromium doesn't provide all info at creation time, instead it sets size and contents and the like piecemeal. With defer:YES, these things short-circuit operations which need to touch the backing store, while with defer:NO they actually make changes. This reverts part of: https://chromium.googlesource.com/chromium/src/+/fa89814df86cd44a BUG=496116 Committed: https://crrev.com/a1b62c42ab4a27a50107b0abdacb0d4b18b0b6a2 Cr-Commit-Position: refs/heads/master@{#333218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/framed_browser_window.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Scott Hess - ex-Googler
5 years, 6 months ago (2015-06-05 22:22:58 UTC) #2
Scott Hess - ex-Googler
WRT my follow-up comment on: https://codereview.chromium.org/1154013009
5 years, 6 months ago (2015-06-05 22:23:32 UTC) #3
Avi (use Gerrit)
lgtm Whatevs.
5 years, 6 months ago (2015-06-06 05:52:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152943004/1
5 years, 6 months ago (2015-06-06 18:16:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-06 18:40:02 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-06 18:40:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1b62c42ab4a27a50107b0abdacb0d4b18b0b6a2
Cr-Commit-Position: refs/heads/master@{#333218}

Powered by Google App Engine
This is Rietveld 408576698