Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: Source/core/page/Page.cpp

Issue 115293005: Add a layer of indirection between Frame and Page (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/Page.cpp
diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp
index 4f2de052953eee2048ea43e404e5b7be50fe4496..4ea05accc86130483bb505ef2db7fb2b5ce2beb4 100644
--- a/Source/core/page/Page.cpp
+++ b/Source/core/page/Page.cpp
@@ -32,6 +32,7 @@
#include "core/frame/DOMTimer.h"
#include "core/frame/DOMWindow.h"
#include "core/frame/Frame.h"
+#include "core/frame/FrameHost.h"
#include "core/frame/FrameView.h"
#include "core/history/HistoryItem.h"
#include "core/inspector/InspectorController.h"
@@ -130,6 +131,7 @@ Page::Page(PageClients& pageClients)
, m_isPainting(false)
#endif
, m_console(PageConsole::create(this))
+ , m_frameHost(FrameHost::create(*this))
{
ASSERT(m_editorClient);
@@ -151,8 +153,8 @@ Page::~Page()
allPages->remove(this);
for (Frame* frame = mainFrame(); frame; frame = frame->tree().traverseNext()) {
- frame->willDetachPage();
- frame->detachFromPage();
+ frame->willDetachFrameHost();
+ frame->detachFromFrameHost();
}
m_inspectorController->inspectedPageDestroyed();

Powered by Google App Engine
This is Rietveld 408576698