Source/core/inspector/InspectorOverlay.cpp - Issue 115293005: Add a layer of indirection between Frame and Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorOverlay.cpp

Issue 115293005: Add a layer of indirection between Frame and Page (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InspectorOverlay.cpp

diff --git a/Source/core/inspector/InspectorOverlay.cpp b/Source/core/inspector/InspectorOverlay.cpp

index c2b10d66da0045442381e6a5836415ea0bbcb2ee..34f6c98f593fae0a8bebd06c7e3046fa38830b03 100644

--- a/Source/core/inspector/InspectorOverlay.cpp

+++ b/Source/core/inspector/InspectorOverlay.cpp

@@ -610,7 +610,7 @@ Page* InspectorOverlay::overlayPage()

overlaySettings.setPluginsEnabled(false);

overlaySettings.setLoadsImagesAutomatically(true);

- RefPtr<Frame> frame = Frame::create(FrameInit::create(0, m_overlayPage.get(), dummyFrameLoaderClient));

+ RefPtr<Frame> frame = Frame::create(FrameInit::create(0, &m_overlayPage->frameHost(), dummyFrameLoaderClient));

frame->setView(FrameView::create(frame.get()));

frame->init();

FrameLoader& loader = frame->loader();