Issue 115293: Add a dep on symupload when using breakpad so it gets built for the bot to th...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115293: Add a dep on symupload when using breakpad so it gets built for the bot to th... (Closed)

Created:
11 years, 7 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add a dep on symupload when using breakpad so it gets built for the bot to then upload symbols. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15957

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/chrome.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

TVL

11 years, 7 months ago (2009-05-13 13:36:02 UTC) #1

I'm not thrilled with this at all.  The app doesn't need this, but it's where
the knowledge about breakpad currently lives.  The other option would be to put
the mac_breakpad var in common.gypi, and then use that to add this dep over in
all.gyp.  But that spreads around the knowledge of breakpad just to get one tool
built.

Expand Messages | Collapse Messages