Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: sky/engine/config.gni

Issue 1152873006: Enable Dart's checked mode in the Sky controller by default for debug builds (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sky/engine/core/script/dart_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 6
7 if (is_android) { 7 if (is_android) {
8 import("//build/config/android/config.gni") 8 import("//build/config/android/config.gni")
9 } 9 }
10 10
11 if (target_cpu == "arm") { 11 if (target_cpu == "arm") {
12 import("//build/config/arm.gni") 12 import("//build/config/arm.gni")
13 } else { 13 } else {
14 # TODO(brettw) remove this once && early-out is checked in. 14 # TODO(brettw) remove this once && early-out is checked in.
15 arm_version = 0 15 arm_version = 0
16 } 16 }
17 17
18 declare_args() { 18 declare_args() {
19 # Enable asserts, even in release builds. 19 # Enable asserts, even in release builds.
20 sky_asserts_always_on = false 20 sky_asserts_always_on = false
21 21
22 # Experimental support for the Dart VM. 22 # Experimental support for the Dart VM.
23 sky_use_dart = false 23 sky_use_dart = false
24
25 # Default to strict mode in debug builds.
26 if (is_debug) {
27 sky_dart_strict_mode = true
28 } else {
29 sky_dart_strict_mode = false
30 }
24 } 31 }
25 32
26 # feature_defines_list --------------------------------------------------------- 33 # feature_defines_list ---------------------------------------------------------
27 34
28 feature_defines_list = [] 35 feature_defines_list = []
29 36
30 if (is_debug) { 37 if (is_debug) {
31 # TODO(GYP) this should also be set when release_valgrind_build is set, 38 # TODO(GYP) this should also be set when release_valgrind_build is set,
32 # but we don't have that flag in the GN build yet. 39 # but we don't have that flag in the GN build yet.
33 feature_defines_list += [ "WTF_USE_DYNAMIC_ANNOTATIONS=1" ] 40 feature_defines_list += [ "WTF_USE_DYNAMIC_ANNOTATIONS=1" ]
34 } 41 }
35 42
36 if (!is_mac) { 43 if (!is_mac) {
37 # Mac OS X has not implemented support for ENABLE(OPENTYPE_VERTICAL) yet. 44 # Mac OS X has not implemented support for ENABLE(OPENTYPE_VERTICAL) yet.
38 feature_defines_list += [ "ENABLE_OPENTYPE_VERTICAL=1" ] 45 feature_defines_list += [ "ENABLE_OPENTYPE_VERTICAL=1" ]
39 } 46 }
40 47
41 if (sky_asserts_always_on) { 48 if (sky_asserts_always_on) {
42 feature_defines_list += [ "ENABLE_ASSERT=1" ] 49 feature_defines_list += [ "ENABLE_ASSERT=1" ]
43 } 50 }
44 51
52 if (sky_dart_strict_mode) {
53 feature_defines_list += [ "ENABLE_DART_STRICT=1" ]
54 }
55
45 if (sky_use_dart) { 56 if (sky_use_dart) {
46 feature_defines_list += [ "WTF_USE_DART=1" ] 57 feature_defines_list += [ "WTF_USE_DART=1" ]
47 } 58 }
48 59
49 # feature_defines_string ------------------------------------------------------- 60 # feature_defines_string -------------------------------------------------------
50 61
51 # Convert the list to a space-separated string for passing to scripts. 62 # Convert the list to a space-separated string for passing to scripts.
52 # This would be the equivalent of passing '<(feature_defines)' in GYP. 63 # This would be the equivalent of passing '<(feature_defines)' in GYP.
53 feature_defines_string = 64 feature_defines_string =
54 exec_script("build/gn_list_to_space_separated_string.py", 65 exec_script("build/gn_list_to_space_separated_string.py",
55 feature_defines_list, 66 feature_defines_list,
56 "trim string") 67 "trim string")
OLDNEW
« no previous file with comments | « no previous file | sky/engine/core/script/dart_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698