Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1152803003: Fix overloaded pipeline integration tests to support underflow. (Closed)

Created:
5 years, 6 months ago by DaleCurtis
Modified:
5 years, 6 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix overloaded pipeline integration tests to support underflow. Also disables the hash tests which seem to be flaking on the bots. I was not able to reproduce this flake locally under valgrind. BUG=492882, 496466 TEST=all pipeline tests pass under valgrind. Committed: https://crrev.com/11d2b2085216156e3cc10c0b701e5582332a52a0 Cr-Commit-Position: refs/heads/master@{#333181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M media/test/pipeline_integration_test.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M tools/valgrind/gtest_exclude/media_unittests.gtest.txt View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
DaleCurtis
5 years, 6 months ago (2015-06-05 21:57:13 UTC) #2
xhwang
lgtm
5 years, 6 months ago (2015-06-05 21:59:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152803003/1
5 years, 6 months ago (2015-06-05 23:39:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-06 00:06:01 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-06 00:06:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11d2b2085216156e3cc10c0b701e5582332a52a0
Cr-Commit-Position: refs/heads/master@{#333181}

Powered by Google App Engine
This is Rietveld 408576698