[net] Make IPEndPoint::GetFamily() return AddressFamily and add GetSockAddrFamily() to be used when…

net/socket/tcp_client_socket_libevent.cc

Index: net/socket/tcp_client_socket_libevent.cc
diff --git a/net/socket/tcp_client_socket_libevent.cc b/net/socket/tcp_client_socket_libevent.cc
index 63d937c940b5e1b9897a9532b94264a29701657f..d1de66dbb36c833d326db9f837572be52f7c653a 100644
--- a/net/socket/tcp_client_socket_libevent.cc
+++ b/net/socket/tcp_client_socket_libevent.cc
@@ -181,7 +181,7 @@ int TCPClientSocketLibevent::Bind(const IPEndPoint& address) {
     return ERR_INVALID_ARGUMENT;
 
   // Create |bound_socket_| and try to bind it to |address|.
-  int error = CreateSocket(address.GetFamily(), &bound_socket_);
+  int error = CreateSocket(address.GetSockAddrFamily(), &bound_socket_);

[eroman, 2012/12/12 21:19:49]

What process did you use to find all the sites for refactor? (since methods
expecting an int for address family will silently compile when passed the enum
version).

[szym, 2012/12/12 22:47:53]

grep the codebase for 'GetFamily\('. I tried introducing a temporary class to
force type safety, but that does not work with switch() statements.

   if (error)
     return MapSystemError(error);
 
@@ -278,7 +278,7 @@ int TCPClientSocketLibevent::DoConnect() {
     bound_socket_ = kInvalidSocket;
   } else {
     // Create a non-blocking socket.
-    connect_os_error_ = CreateSocket(endpoint.GetFamily(), &socket_);
+    connect_os_error_ = CreateSocket(endpoint.GetSockAddrFamily(), &socket_);
     if (connect_os_error_)
       return MapSystemError(connect_os_error_);