Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 1152783005: small cleanups to dart_runtime.js (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly
Modified:
5 years, 6 months ago
Reviewers:
vsm, Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

small cleanups to dart_runtime.js these were caught by the webstorm ES6 plugin biggest one is strict mode doesn't like local functions except at top level, I think becasue the name is not scoped correctly (for historical reasons). Instead `let name = () => ...;` allows correct scoping for `name`. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/1ed893095df96a2b090bbb574919c09c5a3f719d

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -37 lines) Patch
M lib/runtime/dart_runtime.js View 10 chunks +13 lines, -37 lines 3 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
https://codereview.chromium.org/1152783005/diff/1/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (left): https://codereview.chromium.org/1152783005/diff/1/lib/runtime/dart_runtime.js#oldcode29 lib/runtime/dart_runtime.js:29: function formalParameterList(fn) { dead code https://codereview.chromium.org/1152783005/diff/1/lib/runtime/dart_runtime.js#oldcode1025 lib/runtime/dart_runtime.js:1025: return sig; ...
5 years, 6 months ago (2015-05-29 23:02:21 UTC) #2
vsm
lgtm https://codereview.chromium.org/1152783005/diff/1/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (left): https://codereview.chromium.org/1152783005/diff/1/lib/runtime/dart_runtime.js#oldcode29 lib/runtime/dart_runtime.js:29: function formalParameterList(fn) { On 2015/05/29 23:02:20, John Messerly ...
5 years, 6 months ago (2015-05-29 23:07:37 UTC) #3
Jennifer Messerly
5 years, 6 months ago (2015-06-01 16:32:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ed893095df96a2b090bbb574919c09c5a3f719d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698