Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1152763006: Remove outdated list style types (Closed)

Created:
5 years, 7 months ago by rwlbuis
Modified:
5 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-paint_chromium.org, blink-reviews-rendering, blink-reviews-style_chromium.org, dglazkov+blink, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove outdated list style types Blink supports the list of list style types from the old draft: http://www.w3.org/TR/2002/WD-css3-lists-20021107/ However a lot of these are removed in the latest version: http://dev.w3.org/csswg/css-counter-styles-3/ So remove those types that are no longer in the latest spec. I verified for these types that Firefox does not support them (anymore) either. Note that the following styles are kept for compatibility with Firefox which prefixes them with -moz: hangul hangul-consonant ethiopic-halehame ethiopic-halehame-am ethiopic-halehame-ti-er ethiopic-halehame-ti-et urdu Adopt tests to test only the list style types mentioned in the latest spec. BUG=413631 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196756

Patch Set 1 #

Patch Set 2 : Adjust test expectations after removal #

Patch Set 3 : Add more #

Patch Set 4 : Fix more tests #

Patch Set 5 : Add one more test and fix spec references #

Total comments: 1

Patch Set 6 : Fix sorting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -3233 lines) Patch
M LayoutTests/fast/lists/resources/w3-css3-list-styles-alphabetic.css View 1 2 3 4 2 chunks +12 lines, -47 lines 0 comments Download
M LayoutTests/fast/lists/w3-css3-list-styles-alphabetic.html View 1 2 3 4 8 chunks +27 lines, -1011 lines 0 comments Download
M LayoutTests/fast/lists/w3-css3-list-styles-alphabetic-expected.txt View 1 2 3 8 chunks +110 lines, -905 lines 0 comments Download
A LayoutTests/fast/lists/w3-css3-list-styles-deprecated.html View 1 2 3 4 1 chunk +47 lines, -0 lines 0 comments Download
A LayoutTests/fast/lists/w3-css3-list-styles-deprecated-expected.txt View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
M LayoutTests/fast/lists/w3-css3-list-styles-fallback-style.html View 1 2 3 4 9 chunks +31 lines, -250 lines 0 comments Download
M LayoutTests/fast/lists/w3-css3-list-styles-fallback-style-expected.txt View 1 2 3 4 chunks +2 lines, -132 lines 0 comments Download
M LayoutTests/fast/lists/w3-css3-list-styles-numeric.html View 1 2 3 4 9 chunks +10 lines, -124 lines 0 comments Download
M LayoutTests/fast/lists/w3-css3-list-styles-numeric-expected.txt View 1 2 3 4 chunks +0 lines, -66 lines 0 comments Download
D LayoutTests/fast/lists/w3-css3-list-styles-symbolic.html View 1 2 3 1 chunk +0 lines, -83 lines 0 comments Download
D LayoutTests/fast/lists/w3-css3-list-styles-symbolic-expected.txt View 1 2 3 1 chunk +0 lines, -37 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 2 3 4 5 5 chunks +6 lines, -102 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 2 3 3 chunks +4 lines, -36 lines 0 comments Download
M Source/core/layout/LayoutListMarker.cpp View 1 2 3 27 chunks +23 lines, -339 lines 0 comments Download
M Source/core/paint/ListMarkerPainter.cpp View 1 2 3 4 chunks +29 lines, -65 lines 0 comments Download
M Source/core/style/ComputedStyleConstants.h View 1 2 3 3 chunks +4 lines, -36 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
rwlbuis
PTAL. This removes the list styles that I think are safe to remove based on ...
5 years, 6 months ago (2015-05-29 01:57:21 UTC) #2
leviw_travelin_and_unemployed
Seems like this is PSA-on-Blink-Dev-worthy, as it's visible to the web.
5 years, 6 months ago (2015-05-29 18:08:45 UTC) #4
rwlbuis
On 2015/05/29 18:08:45, leviw wrote: > Seems like this is PSA-on-Blink-Dev-worthy, as it's visible to ...
5 years, 6 months ago (2015-06-03 02:58:07 UTC) #6
Timothy Loh
I think this is fine with a PSA to blink-dev :) https://codereview.chromium.org/1152763006/diff/100001/Source/core/css/CSSPrimitiveValueMappings.h File Source/core/css/CSSPrimitiveValueMappings.h (right): ...
5 years, 6 months ago (2015-06-04 04:10:55 UTC) #7
rwlbuis
On 2015/06/04 04:10:55, Timothy Loh wrote: > I think this is fine with a PSA ...
5 years, 6 months ago (2015-06-04 21:40:31 UTC) #8
leviw_travelin_and_unemployed
On 2015/06/04 at 21:40:31, rob.buis wrote: > On 2015/06/04 04:10:55, Timothy Loh wrote: > > ...
5 years, 6 months ago (2015-06-04 21:42:14 UTC) #9
rwlbuis
On 2015/06/04 21:42:14, leviw wrote: > On 2015/06/04 at 21:40:31, rob.buis wrote: > > On ...
5 years, 6 months ago (2015-06-04 23:24:19 UTC) #10
Timothy Loh
On 2015/06/04 23:24:19, rwlbuis wrote: > On 2015/06/04 21:42:14, leviw wrote: > > On 2015/06/04 ...
5 years, 6 months ago (2015-06-09 01:00:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152763006/120001
5 years, 6 months ago (2015-06-09 10:20:59 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 11:38:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #6 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196756

Powered by Google App Engine
This is Rietveld 408576698