Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1152743004: Fix GN midl template for input/output checking (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN midl template for input/output checking An upcoming version of GN will check that inputs to scripts are generated by public dependencies of the script. The MIDL rule is the only failing part of the Windows build. Committed: https://crrev.com/bf622f689a0f60eb57f0d634afbb3dce8b523c80 Cr-Commit-Position: refs/heads/master@{#332450}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/toolchain/win/midl.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 6 months ago (2015-06-02 18:22:41 UTC) #2
scottmg
lgtm
5 years, 6 months ago (2015-06-02 18:24:28 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152743004/1
5 years, 6 months ago (2015-06-02 18:25:25 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-02 19:10:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152743004/1
5 years, 6 months ago (2015-06-02 19:15:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 19:50:58 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 19:52:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf622f689a0f60eb57f0d634afbb3dce8b523c80
Cr-Commit-Position: refs/heads/master@{#332450}

Powered by Google App Engine
This is Rietveld 408576698