Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: Source/platform/graphics/gpu/Extensions3DUtil.cpp

Issue 1152733008: remove |level| in copyVideoTextureToPlatformTexture(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add TODO Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/platform/graphics/gpu/Extensions3DUtil.h ('k') | public/platform/WebMediaPlayer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "platform/graphics/gpu/Extensions3DUtil.h" 6 #include "platform/graphics/gpu/Extensions3DUtil.h"
7 7
8 #include "public/platform/WebGraphicsContext3D.h" 8 #include "public/platform/WebGraphicsContext3D.h"
9 #include "wtf/text/CString.h" 9 #include "wtf/text/CString.h"
10 #include "wtf/text/StringHash.h" 10 #include "wtf/text/StringHash.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 initializeExtensions(); 74 initializeExtensions();
75 } 75 }
76 return m_enabledExtensions.contains(name); 76 return m_enabledExtensions.contains(name);
77 } 77 }
78 78
79 bool Extensions3DUtil::isExtensionEnabled(const String& name) 79 bool Extensions3DUtil::isExtensionEnabled(const String& name)
80 { 80 {
81 return m_enabledExtensions.contains(name); 81 return m_enabledExtensions.contains(name);
82 } 82 }
83 83
84 bool Extensions3DUtil::canUseCopyTextureCHROMIUM(GLenum destFormat, GLenum destT ype, GLint level) 84 bool Extensions3DUtil::canUseCopyTextureCHROMIUM(GLenum destTarget, GLenum destF ormat, GLenum destType, GLint level)
85 { 85 {
86 // FIXME: restriction of (RGB || RGBA)/UNSIGNED_BYTE/(Level 0) should be lif ted when 86 // FIXME: restriction of (RGB || RGBA)/UNSIGNED_BYTE/(Level 0) should be lif ted when
87 // WebGraphicsContext3D::copyTextureCHROMIUM(...) are fully functional. 87 // WebGraphicsContext3D::copyTextureCHROMIUM(...) are fully functional.
88 if ((destFormat == GL_RGB || destFormat == GL_RGBA) 88 if (destTarget == GL_TEXTURE_2D && (destFormat == GL_RGB || destFormat == GL _RGBA)
89 && destType == GL_UNSIGNED_BYTE 89 && destType == GL_UNSIGNED_BYTE
90 && !level) 90 && !level)
91 return true; 91 return true;
92 return false; 92 return false;
93 } 93 }
94 94
95 } // namespace blink 95 } // namespace blink
OLDNEW
« no previous file with comments | « Source/platform/graphics/gpu/Extensions3DUtil.h ('k') | public/platform/WebMediaPlayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698