Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1152733008: remove |level| in copyVideoTextureToPlatformTexture(). (Closed)

Created:
4 years, 11 months ago by dshwang
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, Rik, danakj, dglazkov+blink, krit, eric.carlson_apple.com, feature-media-reviews_chromium.org, f(malita), jbroman, Justin Novosad, mlamouri+watch-blink_chromium.org, pdr+graphicswatchlist_chromium.org, philipj_slow, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

remove |level| in copyVideoTextureToPlatformTexture(). It's because glCopy(Sub)TextureCHROMIUM can handle only 0 level. BUG=443151 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196680

Patch Set 1 #

Total comments: 1

Patch Set 2 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M Source/core/html/HTMLVideoElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/gpu/Extensions3DUtil.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/gpu/Extensions3DUtil.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M public/platform/WebMediaPlayer.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dshwang
could you review? https://codereview.chromium.org/1152733008/diff/1/Source/core/html/HTMLVideoElement.cpp File Source/core/html/HTMLVideoElement.cpp (left): https://codereview.chromium.org/1152733008/diff/1/Source/core/html/HTMLVideoElement.cpp#oldcode227 Source/core/html/HTMLVideoElement.cpp:227: return false; already failed if |level| ...
4 years, 11 months ago (2015-06-05 14:27:45 UTC) #2
Ken Russell (switch to Gerrit)
LGTM Please make sure to follow up and delete the old signature on the Chromium ...
4 years, 11 months ago (2015-06-05 21:59:52 UTC) #5
dshwang
kbr, thx for reviewing. yes, I'll clean up both blink and chromium side. thakis, dglazkov: ...
4 years, 10 months ago (2015-06-08 06:21:28 UTC) #8
dglazkov
lgtm
4 years, 10 months ago (2015-06-08 14:35:44 UTC) #9
dshwang
On 2015/06/08 14:35:44, dglazkov wrote: > lgtm thx for reviewing
4 years, 10 months ago (2015-06-08 15:01:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152733008/40001
4 years, 10 months ago (2015-06-08 15:02:10 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2015-06-08 16:18:01 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196680

Powered by Google App Engine
This is Rietveld 408576698