Issue 1152723010: Shorten flowThreadDescendantWasInserted() and flowThreadDescendantWillBeRemoved().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1152723010: Shorten flowThreadDescendantWasInserted() and flowThreadDescendantWillBeRemoved(). (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)

Modified:
5 years, 6 months ago

Reviewers:
dsinclair, Julien - ping for review

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Shorten flowThreadDescendantWasInserted() and flowThreadDescendantWillBeRemoved(). Offload work to createAndInsertSpannerPlaceholder() and destroySpannerPlaceholder(). No functional changes; just cleanup. R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196672

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -53 lines)			Patch
	M	Source/core/layout/LayoutMultiColumnFlowThread.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	Source/core/layout/LayoutMultiColumnFlowThread.cpp	View		3 chunks	+59 lines, -52 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152723010/1

5 years, 6 months ago (2015-06-08 13:03:01 UTC) #4

commit-bot: I haz the power

5 years, 6 months ago (2015-06-08 13:06:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196672

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages