Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 1152723010: Shorten flowThreadDescendantWasInserted() and flowThreadDescendantWillBeRemoved(). (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Shorten flowThreadDescendantWasInserted() and flowThreadDescendantWillBeRemoved(). Offload work to createAndInsertSpannerPlaceholder() and destroySpannerPlaceholder(). No functional changes; just cleanup. R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -53 lines) Patch
M Source/core/layout/LayoutMultiColumnFlowThread.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/layout/LayoutMultiColumnFlowThread.cpp View 3 chunks +59 lines, -52 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
An upcoming bugfix will benefit from this.
5 years, 6 months ago (2015-06-08 12:54:02 UTC) #1
dsinclair
lgtm
5 years, 6 months ago (2015-06-08 13:02:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152723010/1
5 years, 6 months ago (2015-06-08 13:03:01 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 13:06:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196672

Powered by Google App Engine
This is Rietveld 408576698